[refactor] remove loading skeleton for dynamic popover#14043
Merged
sfc-gh-lwilby merged 1 commit intodevelopfrom Feb 23, 2026
Merged
Conversation
Co-authored-by: lawilby <[email protected]>
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
sfc-gh-lwilby
added
change:refactor
Collaborator
Author
|
@sfc-gh-dmatthews just marked this as "users" because it modifies the user facing behaviour slightly from the original PR. I don't think it impacts the docs, but just so you see the full user facing changes. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the loading skeleton feature from the dynamic popover widget based on a product management decision. When users triggered a rerun by opening an empty popover, a skeleton was previously displayed while waiting for content to arrive. This complexity is no longer needed.
Changes:
- Removed loading skeleton state management (
loadingStartScriptRunId,isLoadingContentderivation) - Simplified
handleToggleandhandleClosecallbacks by removing loading-related logic - Cleaned up unused imports (
ScriptRunContext,ScriptRunState,SquareSkeleton) - Removed the skeleton-specific test that validated the removed feature
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
frontend/lib/src/components/elements/Popover/Popover.tsx |
Removed loading skeleton state, simplified callbacks, cleaned up imports, and updated dependency arrays |
frontend/lib/src/components/elements/Popover/Popover.test.tsx |
Removed test validating skeleton behavior during script runs, cleaned up unused imports |
sfc-gh-bnisco
approved these changes
Feb 23, 2026
sfc-gh-lwilby
deleted the
02-20-_refactor_remove_loading_skeleton_for_dynamic_popover
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removes the loading skeleton from the dynamic popover widget. The skeleton was shown while waiting for content to arrive after a user-triggered rerun, but PM decided it's not needed.
isLoadingContentderivation,loadingStartScriptRunIdtracking, andSquareSkeletonrender fromPopover.tsxhandleToggle/handleCloseby removing loading state managementTesting Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.