Conversation
| @@ -0,0 +1,128 @@ | |||
| import asyncio | |||
There was a problem hiding this comment.
I've been trying to empty our examples/ folder, so I'd like to understand: what is the purpose of this file?
Should this be an e2e test instead? Should we delete it? Or something else?
There was a problem hiding this comment.
It can either go away or be an e2e test. I was using it to visually verify that magic was functioning properly. It seemed potentially useful for anyone down the line who was further debugging magic related stuff - but I'm happy to remove it as well.
What's your pref?
There was a problem hiding this comment.
Sounds like a good candidate for a Cypress test
| @@ -0,0 +1,128 @@ | |||
| import asyncio | |||
There was a problem hiding this comment.
Sounds like a good candidate for a Cypress test
| self._testCode(CODE_WITH_STATEMENT, 1) | ||
|
|
||
| def test_while_statement(self): | ||
| """Test that 'yield' expressions do not get magicked""" |
There was a problem hiding this comment.
Think you copy pasted the method description but didn't update it.
|
I'm going to merge this so we can have it in today's release, but @tconkling please implement the tests described here next week. |
* develop: Release 0.46.0 (streamlit#170) Magic fixes (streamlit#138) [docs] Add analytics; redirect /secret/docs; fix compilation problem (streamlit#149) Fix bug for startup under windows (streamlit#144) Responsive layout (streamlit#104) Add basic PR template Better method signatures (streamlit#88) Publish docs to both /docs and /secret/docs, until we deprecate /secret/docs in January. (streamlit#141) Rename/report2app (streamlit#126)
* develop: (54 commits) Removing uber demo from streamlit repo (streamlit#159) Release 0.46.0 (streamlit#170) Magic fixes (streamlit#138) [docs] Add analytics; redirect /secret/docs; fix compilation problem (streamlit#149) Fix bug for startup under windows (streamlit#144) Responsive layout (streamlit#104) Add basic PR template Better method signatures (streamlit#88) Publish docs to both /docs and /secret/docs, until we deprecate /secret/docs in January. (streamlit#141) Rename/report2app (streamlit#126) Test running streamlit commands "bare" (streamlit#133) Updates to LP and sidebar. (streamlit#134) tests for z-index of date input popover in sidebar (streamlit#131) cypress test for escaping html in markdown (streamlit#125) On a Mac, check if xcode installed before requiring watchdog (streamlit#91) [Docs] Fix st.slider API in tutorial (streamlit#98) Sidebar exceptions (streamlit#107) Fixing unbound local variable (streamlit#110) Support hashing dataframes with unhashable objects. Gracefully f… (streamlit#118) Fix hashing if the object has a name but the name is not a string. (streamlit#117) ...
Re-implements the `examples/magic.py` from #138 as an e2e test.
3 participants
while,async with,async forstatements, and async functionsyieldandyield fromstatements (these were previously being magicked, which resulted in random-seeming "None" values being st.written to the report).examples/magic.pyfile for easy visual testing of these things, which I used while debugging. (The magic unit tests also verify these fixes.)Fixes #135