[feat] Utilize pytest.mark.external_test in 2 tests#13738
Merged
sfc-gh-bnisco merged 1 commit intodevelopfrom Feb 12, 2026
Merged
[feat] Utilize pytest.mark.external_test in 2 tests#13738sfc-gh-bnisco merged 1 commit intodevelopfrom
sfc-gh-bnisco merged 1 commit intodevelopfrom
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
sfc-gh-bnisco
added
change:feature
Contributor
✅ PR preview is ready!
|
This was referenced Jan 29, 2026
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the @pytest.mark.external_test decorator to two test functions to enable them to run in external test environments (e.g., SiS vNext). The tests are updated to use the AppTarget fixture instead of the Page object, which provides a stable abstraction that works across local, external direct, and external host (iframe) modes.
Changes:
- Added
@pytest.mark.external_testtotest_help_tooltip_worksinst_text_test.pyandtest_no_console_errorsinmega_tester_app_test.py - Updated both tests to use the
AppTargetfixture instead ofPage, enabling them to work in external test environments - Removed unused imports and parameters that are no longer needed with
AppTarget
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
e2e_playwright/st_text_test.py |
Added @pytest.mark.external_test to test_help_tooltip_works and migrated from Page to AppTarget fixture |
e2e_playwright/mega_tester_app_test.py |
Added @pytest.mark.external_test(upload_test_assets=True) to test_no_console_errors and migrated from Page/app_port to AppTarget fixture with proper reload and wait logic |
sfc-gh-bnisco
force-pushed
the
01-22-_feat_add_external_tests
branch
from
05ab0e4 to
5f43c64
Compare
sfc-gh-bnisco
force-pushed
the
01-22-_feat_add_app_target
branch
from
2fa0058 to
8bdee90
Compare
sfc-gh-bnisco
force-pushed
the
01-22-_feat_add_external_tests
branch
from
5f43c64 to
5c81234
Compare
sfc-gh-bnisco
force-pushed
the
01-22-_feat_add_app_target
branch
2 times, most recently
from
eaa3de0 to
83ca0ac
Compare
sfc-gh-bnisco
force-pushed
the
01-22-_feat_add_external_tests
branch
2 times, most recently
from
1968bfb to
696cc5b
Compare
lukasmasuch
reviewed
Feb 2, 2026
|
|
||
|
|
||
| def test_no_console_errors(page: Page, app_port: int, browser_name: str): | ||
| @pytest.mark.external_test(upload_test_assets=True) |
Collaborator
There was a problem hiding this comment.
question: What does upload_test_assets do? Could be added to the AGENTS.md file with a brief explanation.
Collaborator
Author
There was a problem hiding this comment.
Added guidance in the code and updated the AGENTS.md file to refer to the code for documentation.
sfc-gh-bnisco
force-pushed
the
01-22-_feat_add_external_tests
branch
from
696cc5b to
8c8547b
Compare
sfc-gh-bnisco
force-pushed
the
01-22-_feat_add_app_target
branch
from
83ca0ac to
9bdbbc0
Compare
sfc-gh-bnisco
force-pushed
the
01-22-_feat_add_app_target
branch
from
9bdbbc0 to
5383b0c
Compare
sfc-gh-bnisco
force-pushed
the
01-22-_feat_add_external_tests
branch
from
8c8547b to
1ebc6fd
Compare
sfc-gh-lmasuch
approved these changes
Feb 12, 2026
Collaborator
Author
Merge activity
|
sfc-gh-bnisco
changed the base branch from
01-22-_feat_add_app_target
to
graphite-base/13738
sfc-gh-bnisco
force-pushed
the
01-22-_feat_add_external_tests
branch
from
1ebc6fd to
212ccab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added the
@pytest.mark.external_testdecorator to tests that should run in external test environments. Updated themega_tester_app_test.pyandst_text_test.pyto use theAppTargetfixture instead of directly using thePageobject.Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.