✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

✅ PR preview is ready!

• [feat] Utilize standardized app_base_url throughout e2e tests #13679
• [feat] Utilize pytest.mark.external_test in 2 tests #13738
• [feat] Add AppTarget class for test abstraction #13737 👈 (View in Graphite)
• [feat] Add external URL runner in e2e playwright #13678
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

📈 Frontend coverage change detected

The frontend unit test (vitest) coverage has increased by 0.0200%

• Current PR: 86.8400% (13884 lines, 1827 missed)
• Latest develop: 86.8200% (13884 lines, 1829 missed)

✅ Coverage change is within normal range.

📊 View detailed coverage comparison

Summary

This PR introduces the AppTarget abstraction and URL utilities to make Playwright E2E tests work consistently across local, external-direct, and external-hosted iframe modes. It updates core fixtures and shared helpers plus documentation to guide usage in external test mode.

Code Quality

Overall structure is clean and the new abstraction is well-contained. One potential pitfall:

• LocatorContext explicitly advertises Locator support, but reset_hovering/reset_focus now call get_by_test_id("stApp") on the passed context, which will scope to the locator subtree and can fail unless the locator actually contains stApp. If tests ever pass a widget-level Locator, this becomes a runtime failure. Consider either restoring the previous Locator.page fallback or tightening the protocol/docs to require a page/frame/app-level context. (e2e_playwright/shared/app_utils.py lines 30-41, 1002-1015)

Test Coverage

No new tests were added. Given these are E2E infrastructure changes, this is acceptable, but note that build_app_url and AppTarget behaviors are not directly exercised by unit tests.

Backwards Compatibility

No user-facing API changes; this is internal test infrastructure. Existing tests should continue to work, though build_app_url changes URL composition logic slightly (e.g., host-only base URLs may no longer be forced to trailing slashes).

Security & Risk

Low risk. Changes are confined to test tooling; no production code paths modified.

Recommendations

1. Clarify or adjust LocatorContext usage so reset_hovering/reset_focus behave correctly with a Locator input (restore locator.page fallback or narrow accepted types). (e2e_playwright/shared/app_utils.py lines 30-41, 1002-1015)
2. Consider making iframe targeting explicit (e.g., .first or an assertion of a single match) so app_target consistently uses the same iframe it updated when multiple iframes match the selector. (e2e_playwright/conftest.py lines 621-632)

Verdict

APPROVED: Solid abstraction and fixture updates with no blocking issues; a couple of minor hardening opportunities noted above.

This is an automated AI review using gpt-5.2-codex-high. Please verify the feedback and use your judgment.

Merge activity

• Feb 12, 8:25 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Feb 12, 8:27 PM UTC: Graphite rebased this pull request as part of a merge.
• Feb 12, 9:08 PM UTC: @sfc-gh-bnisco merged this pull request with Graphite.