Hide developer options when toolbarMode="viewer"#13623
Merged
sfc-gh-dmatthews merged 1 commit intodevelopfrom Jan 17, 2026
Merged
Hide developer options when toolbarMode="viewer"#13623sfc-gh-dmatthews merged 1 commit intodevelopfrom
sfc-gh-dmatthews merged 1 commit intodevelopfrom
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hides developer options from the settings dialog when client.toolbarMode="viewer", making the settings dialog behavior consistent with the app menu. Previously, developer options were hidden from the top-level app menu in viewer mode but were still visible in the settings dialog.
Changes:
- Modified
settingsCallbackin App.tsx to conditionally passallowRunOnSaveto the settings dialog based on both the backend configuration and theshowDevelopmentOptionscheck
sfc-gh-dmatthews
added
security-assessment-completed
change:bugfix
sfc-gh-dmatthews
deleted the
fix]-hide-developer-options-from-settings-in-viewer-mode
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
When
client.toolbarMode="viewer", the developer options are hidden from the top level of the app menu, but not in the settings dialog. This PR hides the developer options (Run on save) in the settings dialog, consistent with thetoolbarModeconfiguration option.This was mentioned in a forum post: https://discuss.streamlit.io/t/hide-development-options-in-settings-panel/120571
Screenshot or video (only for visual changes)
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.