Add more session events metrics e2e tests#13404
Merged
Conversation
vdonato
added
security-assessment-completed
change:other
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds e2e tests to validate session event metrics behavior when websocket connections are interrupted and reconnected. It extends the testing coverage from #13324 by adding tests that verify metrics counters increase correctly.
Key Changes
- Added a helper function
_get_session_event_counts()to fetch and parse session event metrics from the metrics endpoint - Added test to verify metrics increase on a single disconnect/reconnect cycle
- Added test to verify metrics accumulate correctly over multiple disconnect/reconnect cycles
lukasmasuch
added
the
flaky-verify
Collaborator
|
@cursor review |
github-actions
bot
removed
the
flaky-verify
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
In #13324, we added e2e tests to validate that session event metrics were being served but didn't add
tests on the metrics behavior itself because:
This PR goes back to add Playwright tests to validate that session event counter metrics increase
when we expect them to.