Merged
Conversation
Update docstrings and embedded examples. n/a docs only --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license. --------- Co-authored-by: Copilot <[email protected]>
## Describe your changes Fixed type checking issues. ## Testing Plan Covered by CI. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
## Describe your changes Fixes an issue with `st.logo` resizing/shrinking to unexpected sizes if top navigation is used. ## GitHub Issue Link (if applicable) - Closes #13225 ## Testing Plan - Added e2e test. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
## Describe your changes - Fixes a regression where both the Sidebar and Top nav would be visible when navigation is set to `top`. ## GitHub Issue Link (if applicable) Fixes #13224 ## Testing Plan - Adds e2e tests --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
## Describe your changes Authlib (1.6.6) & tornado (6.5.3) got updated, causing some issues with our CI. The authlib session aspect likely also breaks existing usage and requires a patch. Closes #13335 --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license. --------- Co-authored-by: Laura Wilby <[email protected]>
Our current theme hashing only handles top level `[theme]` properties in calculating the theme hash to determine whether theme has been updated. This was sufficient prior to custom theming, but now section theme changes are silently ignored and a re-run does not trigger the expected update. This PR implements comprehensive theme hashing that includes all theme properties - including new subsections (`light`, `dark`, etc.) so changes now properly trigger theme reprocessing.
This PR fixes the interaction issue with theme caching and support of light/dark custom themes - the user-selected theme (Light or Dark) from the Settings menu does not persist between page reloads.
) ## Describe your changes - Improves the handling of keyboard shortcuts to prevent accidental triggering of global single-key shortcuts (like "c", "r", and "a") when the user is typing in editable elements, including those inside Shadow DOM. - Ensures that shortcuts are suppressed in appropriate contexts across both app-level and widget-level handlers. ## GitHub Issue Link (if applicable) ## Testing Plan - Adds unit tests --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
…ts (#13376) ## Describe your changes Added support for the `crossOrigin` attribute on CSS link elements to CCv2 instances. This ensures that CSS resources loaded from different origins follow the same cross-origin policy as other resources in the application. The implementation: 1. Uses the existing `useCrossOriginAttribute` hook to determine the appropriate crossOrigin value 2. Applies the crossOrigin attribute to link elements when loading CSS from relative paths 3. Maintains consistent behavior with other media elements in the application ## Testing Plan - Adds unit tests --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Fixes a regression where starting with an empty column in data editor leads to the value being returned as list. - Closes #13305 - Added unit and e2e tests. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
## Describe your changes Fixes tooltip rendering when help text contains newlines (`\n\n`). Previously, the `:help[]` text directive would break, causing help text to render in the markdown/caption content instead of inside the tooltip. **Solution:** - Pass help text via react context instead of in the directive. - Preserves inline tooltip rendering which is necessary for text alignment to work correctly ## GitHub Issue Link (if applicable) Fixes #13339 ## Testing Plan - [x] E2E Tests **E2E tests:** - `e2e_playwright/st_markdown.py` - Test app with tooltips containing newlines - `e2e_playwright/st_markdown_test.py` - Parameterized tests covering: - `st.markdown` with newlines in default alignment - `st.caption` with newlines - `st.markdown` with center alignment + newlines (verifies design decision) - Negative assertions to ensure text doesn't leak into element content --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
## Describe your changes Fixes the misaligned spinner label and timer text if `show_time=True`: <img width="454" height="106" alt="image" src="https://github.com/user-attachments/assets/e6345d8e-75e0-4579-8d2d-3f081267771b" /> ## GitHub Issue Link (if applicable) - Closes #13387 ## Testing Plan - Testing the visual aspect here is really tricky since a snapshot would be quite indeterministic :( --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Author
✅ PR preview is ready!
|
9ece03f to
b68b514
Compare
b68b514 to
84e232b
Compare
84e232b to
9173f9e
Compare
Contributor
Author
📉 Frontend coverage change detectedThe frontend unit test (vitest) coverage has decreased by 0.0400%
💡 Consider adding more unit tests to maintain or improve coverage. |
sfc-gh-bnisco
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR to merge release branch into develop.
Release version: 1.52.2