Merged
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
sfc-gh-bnisco
added
the
change:bugfix
Graphite App
Contributor
✅ PR preview is ready!
|
sfc-gh-bnisco
added
impact:internal
Graphite App
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses mypy type checking issues by removing unnecessary type ignore comments and adding appropriate type casts. The changes improve type safety without affecting functionality.
Key Changes:
- Removed obsolete
# type: ignorecomments that are no longer needed with updated pandas type stubs - Added
cast("Any", column_name)to handle DataFrame column name type flexibility - Reformatted a list comprehension to single-line format for consistency
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/streamlit/elements/widgets/data_editor.py |
Removed type ignore comment from to_flat_index() call and added cast for DataFrame column indexing to handle non-string column names |
lib/streamlit/elements/lib/pandas_styler_utils.py |
Removed type ignore comment from iloc assignment that is no longer needed |
Contributor
📈 Frontend coverage change detectedThe frontend unit test (vitest) coverage has increased by 0.0600%
🎉 Great job on improving test coverage! |
lukasmasuch
pushed a commit
that referenced
this pull request
Dec 3, 2025
## Describe your changes Fixed type checking issues. ## Testing Plan Covered by CI. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixed type checking issues.
Testing Plan
Covered by CI.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.