Skip to content

Remove experimental query params#13142

Merged
sfc-gh-lmasuch merged 6 commits intodevelopfrom
remove-experimental-query-params
Jan 15, 2026
Merged

Remove experimental query params#13142
sfc-gh-lmasuch merged 6 commits intodevelopfrom
remove-experimental-query-params

Conversation

@lukasmasuch
Copy link
Copy Markdown
Collaborator

@lukasmasuch lukasmasuch commented Nov 27, 2025

Describe your changes

Removes experimental_get_query_params and experimental_set_query_params which have been deprecated for > 2 years and replaced with the new st.query_params API.


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Copy Markdown
Contributor

snyk-io bot commented Nov 27, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 27, 2025

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-13142/streamlit-1.53.0-py3-none-any.whl
📦 @streamlit/component-v2-lib Download from artifacts
🕹️ Preview app pr-13142.streamlit.app (☁️ Deploy here if not accessible)

@lukasmasuch lukasmasuch added change:breaking PR contains breaking change that affects backwards compatibility change:refactor PR contains code refactoring without behavior change impact:users PR changes affect end users security-assessment-completed labels Nov 27, 2025
@lukasmasuch lukasmasuch marked this pull request as ready for review November 27, 2025 11:40
Copilot AI review requested due to automatic review settings November 27, 2025 11:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated experimental_get_query_params and experimental_set_query_params functions, which have been deprecated for over 2 years and replaced by the st.query_params API. The removal is comprehensive, eliminating all implementation code, tests, and tracking mechanisms for the experimental API.

Key Changes:

  • Removed the experimental query params implementation module and all related tracking/enforcement code
  • Deleted all unit and E2E tests specific to the experimental API
  • Updated existing tests to use the current st.query_params API
  • Cleaned up unused imports resulting from the removal

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/streamlit/__init__.py Removed imports and deprecated function wrappers for experimental query params
lib/streamlit/commands/experimental_query_params.py Deleted entire module containing experimental API implementation
lib/streamlit/runtime/scriptrunner_utils/script_run_context.py Removed tracking fields and methods for API usage enforcement
lib/streamlit/runtime/state/query_params.py Removed all calls to _ensure_single_query_api_used() method
lib/tests/streamlit/testing/app_test_test.py Updated tests to use st.query_params instead of experimental functions
lib/tests/streamlit/streamlit_test.py Removed experimental functions from export list test
lib/tests/streamlit/runtime/scriptrunner_utils/script_run_context_test.py Removed tests for API enforcement and cleaned up unused imports
lib/tests/streamlit/commands/experimental_query_params_test.py Deleted entire test file for experimental API
e2e_playwright/st_experimental_get_query_params.py Deleted E2E test app
e2e_playwright/st_experimental_get_query_params_test.py Deleted E2E test
e2e_playwright/st_experimental_set_query_params.py Deleted E2E test app
e2e_playwright/st_experimental_set_query_params_test.py Deleted E2E test
e2e_playwright/st_both_query_params_error.py Deleted E2E test app for API conflict
e2e_playwright/st_both_query_params_error_test.py Deleted E2E test for API conflict
e2e_playwright/st_selectbox.py Updated test data to reference new filename st_query_params.py
frontend/lib/src/util/fuzzyFilterSelectOptions.test.ts Updated test data to reference new filename
frontend/app/src/App.test.tsx Updated comment to reference current st.query_params API

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Copy Markdown
Contributor

@sfc-gh-nbellante sfc-gh-nbellante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-lmasuch sfc-gh-lmasuch enabled auto-merge (squash) January 15, 2026 21:33
@github-actions
Copy link
Copy Markdown
Contributor

📉 Frontend coverage change detected

The frontend unit test (vitest) coverage has decreased by 0.0500%

  • Current PR: 86.5100% (12889 lines, 1738 missed)
  • Latest develop: 86.5600% (12889 lines, 1732 missed)

💡 Consider adding more unit tests to maintain or improve coverage.

📊 View detailed coverage comparison

@sfc-gh-lmasuch sfc-gh-lmasuch merged commit 137d919 into develop Jan 15, 2026
46 checks passed
@sfc-gh-lmasuch sfc-gh-lmasuch deleted the remove-experimental-query-params branch January 15, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:breaking PR contains breaking change that affects backwards compatibility change:refactor PR contains code refactoring without behavior change impact:users PR changes affect end users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants