Fix query parameters not preserved on back navigation #13129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
lukasmasuch
changed the title
lukasmasuch
added
security-assessment-completed
lukasmasuch
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where query parameters are not preserved when users navigate back using the browser's back button in multi-page apps. The fix adds a preserveQueryParams parameter that is set to true during browser history navigation to prevent query params from being cleared.
Key Changes:
- Modified
onPageChangeto accept an optionalpreserveQueryParamsparameter - Updated
sendRerunBackMsgto conditionally skip clearing query params whenpreserveQueryParamsis true - Added browser back navigation handling to preserve query params from the URL
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
frontend/app/src/App.tsx |
Added preserveQueryParams parameter to onPageChange and sendRerunBackMsg methods; modified logic to skip clearing query params during history navigation |
frontend/app/src/App.test.tsx |
Added unit test to verify query params are preserved in rerun message after browser back button navigation |
e2e_playwright/multipage_apps_v2/mpa_v2_basics_test.py |
Added e2e test to verify query params are displayed correctly after browser back navigation |
lukasmasuch
deleted the
fix/query-params-not-preserved-on-back-navigation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes an issue where query parameters don't get synced correctly on browser back navigation.
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.