Reduce entry bundle size - Part 4 #13115

mayagbarnes · 2025-11-25T01:29:30Z

Describe your changes

Attempt to improve initial load time by reducing dependencies included in entry bundle.

Changes made:

~~Remove apache-arrow from entry bundle~~ ${\color{red}Delayed}$ - add_rows deprecation
- ~~Refactor ElementNode to move Quiver instantiation logic into components~~
Lazy load FormSubmitContent & ComponentInstance

Bundle Analysis:

Before: 2.38 MB & After: 2.36 MB

snyk-io · 2025-11-25T01:29:38Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

mayagbarnes · 2025-11-25T01:29:49Z

Reduce entry bundle size - Part 5 #13128
Reduce entry bundle size - Part 4 #13115 👈 (View in Graphite)
Reduce entry bundle size - Part 3 #13099
Reduce entry bundle size - Part 2 #13077
Reduce entry bundle size - Part 1 #13071
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-11-25T01:29:51Z

✅ PR preview is ready!

Name	Link
📦 Wheel file	https://core-previews.s3-us-west-2.amazonaws.com/pr-13115/streamlit-1.51.0-py3-none-any.whl
📦 `@streamlit/component-v2-lib`	Download from artifacts
🕹️ Preview app	pr-13115.streamlit.app (☁️ Deploy here if not accessible)

github-actions · 2025-11-25T01:35:50Z

📉 Significant wheel size change detected

The wheel file size has decreased by 0.26% (threshold: 0.25%)

Current PR: 8758.53 KB
Latest develop: 8781.64 KB

Please verify that this change is expected.

github-actions · 2025-11-25T01:36:14Z

📉 Significant bundle size change detected

Metric	This Branch	`develop`	Change (%)
Total (gzip)	8.16 MiB	8.16 MiB	-0.01%
Entry (gzip)	749.54 KiB	756.8 KiB	-0.96%

Please verify that this change is expected.

📊 View detailed bundle comparison

Copilot

Pull request overview

This PR successfully reduces the entry bundle size from 2.38 MB to 2.15 MB by removing apache-arrow from the entry bundle. It achieves this by refactoring ElementNode to defer Quiver instantiation to component-level, storing raw Arrow proto data instead.

Key Changes

Refactored ElementNode to store raw Arrow proto data and accumulate addedRowsList instead of instantiating Quiver eagerly
Moved Quiver instantiation logic from ElementNode to components (DataFrame, ArrowTable, ArrowVegaLiteChart)
Added new utility functions in dataframeUtils.ts for consistent Quiver creation and merging
Lazy-loaded ComponentInstance and FormSubmitContent for additional bundle size reduction
Updated error messages to remove stack traces for cleaner UI display

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`frontend/lib/src/render-tree/ElementNode.ts`	Refactored to store raw Arrow proto data and `addedRowsList` instead of instantiating Quiver; removed merge helper functions
`frontend/lib/src/render-tree/ElementNode.test.ts`	Updated tests to verify raw data storage instead of Quiver instantiation
`frontend/lib/src/dataframes/dataframeUtils.ts`	New utility file with functions for Quiver creation and merging
`frontend/lib/src/dataframes/dataframeUtils.test.ts`	Comprehensive tests for new utility functions
`frontend/lib/src/dataframes/arrowConcatUtils.ts`	Refactored error messages to single-line format without stack traces
`frontend/lib/src/dataframes/__snapshots__/Quiver.test.ts.snap`	Updated snapshots reflecting new error message format
`frontend/lib/src/dataframes/Quiver.ts`	Added `createError` method for user-facing errors without stack traces
`frontend/lib/src/components/widgets/DataFrame/ReadOnlyGrid.tsx`	Updated to accept `IArrow \| Quiver` and extract data bytes for DataFrame
`frontend/lib/src/components/widgets/DataFrame/ReadOnlyGrid.test.tsx`	Updated tests to pass `IArrow` instead of Quiver instances
`frontend/lib/src/components/widgets/DataFrame/DataFrame.tsx`	Added `useMemo` to instantiate Quiver from proto and merge `addedRowsList`
`frontend/lib/src/components/widgets/DataFrame/DataFrame.test.tsx`	Updated to pass raw data instead of Quiver instances in props
`frontend/lib/src/components/elements/ArrowVegaLiteChart/arrowUtils.ts`	Added `buildVegaLiteChartElement` function to construct VegaLiteChartElement from proto and added rows
`frontend/lib/src/components/elements/ArrowVegaLiteChart/arrowUtils.test.ts`	Added comprehensive tests for `buildVegaLiteChartElement`
`frontend/lib/src/components/elements/ArrowVegaLiteChart/ArrowVegaLiteChart.tsx`	Updated to use `buildVegaLiteChartElement` and pass raw data to ReadOnlyGrid
`frontend/lib/src/components/elements/ArrowVegaLiteChart/ArrowVegaLiteChart.test.tsx`	Updated to pass proto instead of VegaLiteChartElement
`frontend/lib/src/components/elements/ArrowTable/ArrowTable.tsx`	Added `useMemo` to instantiate Quiver from proto and merge `addedRowsList`
`frontend/lib/src/components/elements/ArrowTable/ArrowTable.test.tsx`	Updated to pass raw data in proto instead of separate Quiver instances
`frontend/lib/src/components/core/Block/ElementNodeRenderer.tsx`	Updated to extract raw data from ElementNode and lazy-load ComponentInstance and FormSubmitContent
`e2e_playwright/st_add_rows_test.py`	Updated test selector from `stAlert` to more specific `stAlertContentError`

Comments suppressed due to low confidence (1)

frontend/lib/src/dataframes/Quiver.ts:320

This string appears to be missing a space after 'of'.

          " If you do not need the Styler's styles, try passing the .data attribute of" +

frontend/lib/src/dataframes/Quiver.ts

frontend/lib/src/components/widgets/DataFrame/ReadOnlyGrid.tsx

frontend/lib/src/components/elements/ArrowVegaLiteChart/arrowUtils.ts

frontend/lib/src/dataframes/Quiver.ts

github-actions · 2025-11-25T20:31:34Z

📉 Frontend coverage change detected

The frontend unit test (vitest) coverage has decreased by 0.0100%

Current PR: 87.5800% (51147 lines, 6352 missed)
Latest develop: 87.5900% (51141 lines, 6346 missed)

✅ Coverage change is within normal range.

📊 View detailed coverage comparison

mayagbarnes · 2025-11-26T20:11:05Z

frontend/lib/src/components/core/Block/ElementNodeRenderer.tsx

@@ -81,8 +80,6 @@ import { Skeleton } from "~lib/components/elements/Skeleton"
 import TextElement from "~lib/components/elements/TextElement"
 import ErrorBoundary from "~lib/components/shared/ErrorBoundary"
 import Heading from "~lib/components/shared/StreamlitMarkdown/Heading"
-import { ComponentInstance } from "~lib/components/widgets/CustomComponent"


In addition to the couple added lazy loads, this was just reorganizing components back into alphabetical order under each elements/widgets comment

mayagbarnes · 2025-11-26T20:16:04Z

frontend/lib/src/dataframes/Quiver.ts

@@ -299,23 +299,28 @@ export class Quiver {
    return this._data.getChildAt(columnIndex)?.get(rowIndex)
  }

+  /**


These errors are now rendered through the ErrorBoundary in ElementNodeRenderer which does not support markdown in the message.

lukasmasuch · 2025-11-27T14:41:15Z

We just deprecated the add_rows feature since it has almost no usage but a lot of overhead: #13063 #13080 If we don't get a strong feedback to keep it, we will probably remove this soon. Based on that, I'm not sure if we should touch this feature right now but I will take a closer look at the changes a bit later.

Maybe if possible we can prioritize the #13128 and Lazy load FormSubmitContent & ComponentInstance aspect since this looks good to go for 1.52 release

lukasmasuch

LGTM 👍

mayagbarnes mentioned this pull request Nov 25, 2025

Reduce entry bundle size - Part 3 #13099

Merged

This was referenced Nov 25, 2025

Reduce entry bundle size - Part 1 #13071

Merged

Reduce entry bundle size - Part 2 #13077

Merged

mayagbarnes changed the title ~~Reorganize and lazy load couple other components~~ Reduce entry bundle size - Part 4 Nov 25, 2025

mayagbarnes added change:refactor PR contains code refactoring without behavior change impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR labels Nov 25, 2025 — with Graphite App

sfc-gh-mbarnes force-pushed the reduce-bundle-4 branch 2 times, most recently from 0457491 to 5183381 Compare November 25, 2025 05:59

mayagbarnes requested a review from Copilot November 25, 2025 07:47

Copilot started reviewing on behalf of mayagbarnes November 25, 2025 07:48 View session

Copilot finished reviewing on behalf of mayagbarnes November 25, 2025 07:53

Copilot AI reviewed Nov 25, 2025

View reviewed changes

mayagbarnes changed the base branch from reduce-bundle-3 to graphite-base/13115 November 25, 2025 19:46

sfc-gh-mbarnes force-pushed the reduce-bundle-4 branch from 5183381 to 7fc4df5 Compare November 25, 2025 20:20

sfc-gh-mbarnes force-pushed the graphite-base/13115 branch from a6e325e to 9cda13b Compare November 25, 2025 20:20

mayagbarnes changed the base branch from graphite-base/13115 to reduce-bundle-3 November 25, 2025 20:20

Base automatically changed from reduce-bundle-3 to develop November 25, 2025 21:21

mayagbarnes marked this pull request as ready for review November 25, 2025 22:06

sfc-gh-mbarnes force-pushed the reduce-bundle-4 branch from 7fc4df5 to 6b561b7 Compare November 25, 2025 22:07

mayagbarnes mentioned this pull request Nov 25, 2025

Reduce entry bundle size - Part 5 #13128

Merged

sfc-gh-mbarnes force-pushed the reduce-bundle-4 branch from 6b561b7 to a7ec894 Compare November 26, 2025 01:57

mayagbarnes commented Nov 26, 2025

View reviewed changes

Reorganize and lazy load couple other components

930a516

sfc-gh-mbarnes force-pushed the reduce-bundle-4 branch from a7ec894 to 930a516 Compare November 28, 2025 09:30

lukasmasuch approved these changes Nov 28, 2025

View reviewed changes

mayagbarnes merged commit b6a08d9 into develop Nov 28, 2025
43 checks passed

mayagbarnes deleted the reduce-bundle-4 branch November 28, 2025 10:59

Reduce entry bundle size - Part 4 #13115

Reduce entry bundle size - Part 4 #13115

Uh oh!

Conversation

mayagbarnes commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes

Bundle Analysis:

Uh oh!

snyk-io bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

mayagbarnes commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ PR preview is ready!

Uh oh!

github-actions bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📉 Significant wheel size change detected

Uh oh!

github-actions bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📉 Significant bundle size change detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📉 Frontend coverage change detected

Uh oh!

mayagbarnes Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mayagbarnes Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

lukasmasuch commented Nov 27, 2025

Uh oh!

lukasmasuch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mayagbarnes commented Nov 25, 2025 •

edited

Loading

snyk-io bot commented Nov 25, 2025 •

edited

Loading

mayagbarnes commented Nov 25, 2025 •

edited

Loading

github-actions bot commented Nov 25, 2025 •

edited

Loading

github-actions bot commented Nov 25, 2025 •

edited

Loading

github-actions bot commented Nov 25, 2025 •

edited

Loading

github-actions bot commented Nov 25, 2025 •

edited

Loading

mayagbarnes Nov 26, 2025 •

edited

Loading