Skip to content

Fix typo in test method names: 'implict' → 'implicit'#13106

Merged
lukasmasuch merged 2 commits intodevelopfrom
copilot/fix-typo-in-test-method-name
Nov 24, 2025
Merged

Fix typo in test method names: 'implict' → 'implicit'#13106
lukasmasuch merged 2 commits intodevelopfrom
copilot/fix-typo-in-test-method-name

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 24, 2025 •
edited by cursor bot
Loading

Describe your changes

Corrected spelling in two test method names in arrow_add_rows_test.py:

  • test_charts_with_implict_x_and_y → test_charts_with_implicit_x_and_y
  • test_charts_with_implict_x_and_explicit_y → test_charts_with_implicit_x_and_explicit_y

Screenshot or video (only for visual changes)

N/A

GitHub Issue Link (if applicable)

N/A

Testing Plan

  • Explanation of why no additional tests are needed: These are test method name corrections only; no functional changes. All existing tests continue to pass.
  • Unit Tests (JS and/or Python)
  • E2E Tests
  • Any manual testing needed?

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

Original prompt 
Please apply the following diffs and create a pull request.
Once the PR is ready, give it a title based on the messages of the fixes being applied.

[{"message":"The method name contains a typo: 'implict' should be 'implicit'.","fixFiles":[{"filePath":"lib/tests/streamlit/elements/arrow_add_rows_test.py","diff":"diff --git a/lib/tests/streamlit/elements/arrow_add_rows_test.py b/lib/tests/streamlit/elements/arrow_add_rows_test.py\n--- a/lib/tests/streamlit/elements/arrow_add_rows_test.py\n+++ b/lib/tests/streamlit/elements/arrow_add_rows_test.py\n@@ -44,7 +44,7 @@\n     \"\"\"Test dg.add_rows.\"\"\"\n \n     @parameterized.expand(ST_CHART_ARGS)\n-    def test_charts_with_implict_x_and_y(self, chart_command):\n+    def test_charts_with_implicit_x_and_y(self, chart_command):\n         expected = pd.DataFrame(\n             {\n                 f\"index{_PROTECTION_SUFFIX}\": [1, 2, 3, 1, 2, 3, 1, 2, 3],\n"}]},{"message":"The method name contains a typo: 'implict' should be 'implicit'.","fixFiles":[{"filePath":"lib/tests/streamlit/elements/arrow_add_rows_test.py","diff":"diff --git a/lib/tests/streamlit/elements/arrow_add_rows_test.py b/lib/tests/streamlit/elements/arrow_add_rows_test.py\n--- a/lib/tests/streamlit/elements/arrow_add_rows_test.py\n+++ b/lib/tests/streamlit/elements/arrow_add_rows_test.py\n@@ -92,7 +92,7 @@\n         pd.testing.assert_frame_equal(proto, expected)\n \n     @parameterized.expand(ST_CHART_ARGS)\n-    def test_charts_with_implict_x_and_explicit_y(self, chart_command):\n+    def test_charts_with_implicit_x_and_explicit_y(self, chart_command):\n         expected = pd.DataFrame(\n             {\n                 f\"index{_PROTECTION_SUFFIX}\": [1, 2, 3],\n"}]}]

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Note

Fix typos in two test method names in lib/tests/streamlit/elements/arrow_add_rows_test.py ('implict' → 'implicit').

Written by Cursor Bugbot for commit e72e00c. This will update automatically on new commits. Configure here.

Copilot AI self-assigned this Nov 24, 2025
@snyk-io
Copy link
Copy Markdown
Contributor

snyk-io bot commented Nov 24, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 24, 2025 •
edited
Loading

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-13106/streamlit-1.51.0-py3-none-any.whl
📦 @streamlit/component-v2-lib Download from artifacts
🕹️ Preview app pr-13106.streamlit.app (☁️ Deploy here if not accessible)

@lukasmasuch lukasmasuch added security-assessment-completed change:other PR contains other type of change impact:internal PR changes only affect internal code labels Nov 24, 2025
Copilot AI changed the title [WIP] Fix typo in test method name for implicit parameter Fix typo in test method names: 'implict' → 'implicit' Nov 24, 2025
Copilot AI requested a review from lukasmasuch November 24, 2025 13:45
@lukasmasuch lukasmasuch marked this pull request as ready for review November 24, 2025 13:46
Copilot AI review requested due to automatic review settings November 24, 2025 13:46
lukasmasuch
lukasmasuch approved these changes Nov 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lukasmasuch lukasmasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lukasmasuch lukasmasuch enabled auto-merge (squash) November 24, 2025 13:46
Copilot AI reviewed Nov 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects a spelling typo in two test method names within the test suite.

  • Changed "implict" to "implicit" in two test method names
  • No functional changes, only naming corrections

@lukasmasuch lukasmasuch merged commit 7e5ada9 into develop Nov 24, 2025
65 of 94 checks passed
@lukasmasuch lukasmasuch deleted the copilot/fix-typo-in-test-method-name branch November 24, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@sfc-gh-lmasuch sfc-gh-lmasuch sfc-gh-lmasuch approved these changes

+1 more reviewer

@lukasmasuch lukasmasuch lukasmasuch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukasmasuch lukasmasuch

Copilot code review Copilot

Labels

change:other PR contains other type of change impact:internal PR changes only affect internal code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lukasmasuch @sfc-gh-lmasuch