Add deprecation note to add_rows command
#13080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmasuch
changed the title
add_rows commandadd_rows command
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
lukasmasuch
added
security-assessment-completed
lukasmasuch
changed the title
add_rows commandadd_rows command
lukasmasuch
changed the title
add_rows commandadd_rows command
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a soft deprecation of the add_rows command by adding deprecation warnings and documentation notes. The purpose is to gather user feedback on whether this feature is still valuable before considering full removal.
Key Changes:
- Added deprecation warning that logs to console (not shown in browser) when
add_rowsis called - Updated docstring with an
.. important::directive noting the deprecation and linking to GitHub issue #13063 - Added unit test to verify the deprecation warning is triggered correctly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lib/streamlit/elements/arrow.py |
Added deprecation warning call and docstring note to the add_rows method |
lib/tests/streamlit/elements/arrow_add_rows_test.py |
Added unit test to verify deprecation warning is logged when add_rows is called |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
sfc-gh-bnisco
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Soft deprecation of
add_rows(showing logs + note on docs) to gather more feedback on the value and use-cases of the feature. More context: #13063GitHub Issue Link (if applicable)
add_rows#13063Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.