Fix empty Markdown code blocks rendering as “undefined”#13074
Merged
sfc-gh-bnisco merged 15 commits intostreamlit:developfrom Nov 21, 2025
Merged
Fix empty Markdown code blocks rendering as “undefined”#13074sfc-gh-bnisco merged 15 commits intostreamlit:developfrom
sfc-gh-bnisco merged 15 commits intostreamlit:developfrom
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
sfc-gh-bnisco
added
feature:markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where empty Markdown code blocks render as "undefined" instead of being empty. The fix processes the children prop to filter out "undefined" strings and handle null/empty values properly.
Key changes:
- Made the
childrenprop optional in the component interface - Added preprocessing logic to handle various children states (array, null, string, "undefined")
- Simplified the copy button conditional rendering to use the processed text
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Contributor
Author
|
@sfc-gh-bnisco I'm not very good at front-end development. Could you review my PR? |
sfc-gh-bnisco
approved these changes
Nov 21, 2025
Collaborator
sfc-gh-bnisco
left a comment
sfc-gh-bnisco
left a comment
There was a problem hiding this comment.
Thank you for the contribution and iterations @ashm-dev! I made some updates and added tests.
sfc-gh-nbellante
approved these changes
Nov 21, 2025
Contributor
sfc-gh-nbellante
left a comment
sfc-gh-nbellante
left a comment
There was a problem hiding this comment.
Only 1 q, other than that LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12986