Skip to content

Conversation

@tomtung
Copy link
Contributor

@tomtung tomtung commented Nov 20, 2025

Describe your changes

https://packaging.pypa.io/en/stable/index.html

The packaging library uses calendar-based versioning (YY.N).

So major version increase doesn't mean breaking changes. There's no reason to cap this, and it only makes it more likely to cause dependency conflicts.

Testing Plan

  • Explanation of why no additional tests are needed
  • Unit Tests (JS and/or Python)
  • E2E Tests
  • Any manual testing needed?

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

https://packaging.pypa.io/en/stable/index.html
> The `packaging` library uses calendar-based versioning (`YY.N`).

So major version increase doesn't mean breaking changes. There's no reason to cap this, and it only makes it more likely to cause dependency conflicts.
@tomtung tomtung requested a review from a team as a code owner November 20, 2025 18:24
@snyk-io
Copy link
Contributor

snyk-io bot commented Nov 20, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@sfc-gh-bnisco sfc-gh-bnisco added change:bugfix PR contains bug fix implementation impact:users PR changes affect end users labels Nov 20, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the upper bound version constraint on the packaging dependency, changing it from "packaging>=20, <26" to "packaging>=20", since the package uses calendar-based versioning where major version increases don't indicate breaking changes.

Key Changes

  • Removed upper bound version cap from the packaging dependency specification
  • Added explanatory comment about the rationale (calendar-based versioning)

@sfc-gh-bnisco sfc-gh-bnisco self-assigned this Nov 20, 2025
@sfc-gh-bnisco sfc-gh-bnisco added the security-assessment-completed Security assessment has been completed for PR label Nov 21, 2025
Copy link
Collaborator

@sfc-gh-bnisco sfc-gh-bnisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! LGTM

@sfc-gh-bnisco sfc-gh-bnisco merged commit 3acc23a into streamlit:develop Nov 21, 2025
40 of 42 checks passed
@tomtung tomtung deleted the patch-1 branch November 21, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:bugfix PR contains bug fix implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants