Reduce entry bundle size - Part 1 #13071
Merged
+80
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
✅ PR preview is ready!
|
mayagbarnes
changed the title
mayagbarnes
changed the title
mayagbarnes
added
change:refactor
Graphite App
sfc-gh-mbarnes
force-pushed
the
reduce-bundle
branch
from
7284879 to
c74645b
Compare
Contributor
📉 Significant wheel size change detectedThe wheel file size has decreased by 0.40% (threshold: 0.25%)
Please verify that this change is expected. |
sfc-gh-mbarnes
force-pushed
the
reduce-bundle
branch
from
c74645b to
d38f456
Compare
Contributor
📉 Significant bundle size change detected
Please verify that this change is expected. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the entry bundle size by approximately 33% (from 7.64 MB to 5.11 MB) through lazy loading of heavy dependencies and removing moment from the entry point.
Key changes:
- Replaced
momentusage in App.tsx with a new nativegetScreencastTimestamp()utility function - Lazy loaded three components to exclude their heavy dependencies from the entry bundle:
ArrowTable(moment-timezone),Metric(vega-lite), andJson(react-json-view) - Added comprehensive test coverage for the new timestamp utility function
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/lib/src/util/utils.ts | Added getScreencastTimestamp() function to generate timestamps for screencast filenames without moment dependency |
| frontend/lib/src/util/utils.test.ts | Added comprehensive test suite for getScreencastTimestamp() covering edge cases like padding, midnight, and year boundaries |
| frontend/lib/src/index.ts | Exported getScreencastTimestamp and reordered DownloadContext export alphabetically |
| frontend/lib/src/components/core/Block/ElementNodeRenderer.tsx | Converted ArrowTable, Json, and Metric to lazy loaded components to reduce entry bundle size |
| frontend/app/src/App.tsx | Replaced moment().format() with getScreencastTimestamp() for screencast filename generation |
lukasmasuch
approved these changes
Nov 24, 2025
Comment on lines
-77
to
78
| import ArrowTable from "~lib/components/elements/ArrowTable" | ||
| import DocString from "~lib/components/elements/DocString" | ||
| import ExceptionElement from "~lib/components/elements/ExceptionElement" |
Collaborator
There was a problem hiding this comment.
question: does it make sense to also lazy-load the other elements here in follow-up PRs?
Collaborator
Author
There was a problem hiding this comment.
I still have some testing to do around this to confirm, but will be part of future PR if it moves needle 👍🏼
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
sfc-gh-mbarnes
force-pushed
the
reduce-bundle
branch
from
1468883 to
9458342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Attempt to improve initial load time by reducing dependencies included in entry bundle.
Dependencies removed from entry:
moment-timezone: Removed moment usage fromApp& lazy loadedArrowTablevega-lite: Lazy loadMetriccomponent (already lazy-loadedArrowVegaLiteChart)react-json-view: Lazy loadJsoncomponentBundle Analysis:
Before (left): 7.64 MB & After (right): 5.11 MB
