Merged
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sfc-gh-aamadhavan
added
security-assessment-completed
impact:users
sfc-gh-aamadhavan
force-pushed
the
aakarshm/date-time-input-1
branch
from
26407f5 to
ffaed7f
Compare
Contributor
📈 Python coverage change detectedThe Python unit test coverage has increased by 0.0574%
🎉 Great job on improving test coverage! Coverage by files
|
Contributor
📈 Frontend coverage change detectedThe frontend unit test (vitest) coverage has increased by 0.1100%
🎉 Great job on improving test coverage! |
sfc-gh-aamadhavan
force-pushed
the
aakarshm/date-time-input-1
branch
from
ffaed7f to
bdcf326
Compare
sfc-gh-aamadhavan
force-pushed
the
aakarshm/date-time-input-1
branch
from
80ab119 to
12fd2db
Compare
sfc-gh-aamadhavan
force-pushed
the
aakarshm/date-time-input-1
branch
from
4432fa3 to
7ea5e4d
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
frontend/lib/src/components/widgets/DateTimeInput/DateTimeInput.tsx
Outdated
Show resolved
Hide resolved
sfc-gh-aamadhavan
force-pushed
the
aakarshm/date-time-input-1
branch
from
7ea5e4d to
4678ed5
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new st.datetime_input widget that allows users to select both date and time values. The implementation follows Streamlit's established patterns for widget creation, including full backend support, React frontend component, protobuf message definitions, and comprehensive test coverage across Python unit tests, TypeScript unit tests, and Playwright E2E tests.
Key changes:
- New datetime picker widget combining date and time selection with configurable step intervals and format options
- Backend support for various input types (datetime, date, time, ISO strings, "now" keyword)
- AppTest integration for programmatic testing
- Visual snapshot testing across multiple browsers and themes
Reviewed Changes
Copilot reviewed 17 out of 95 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
proto/streamlit/proto/DateTimeInput.proto |
Defines protobuf message structure for datetime widget communication |
proto/streamlit/proto/Element.proto |
Integrates DateTimeInput into Element union |
lib/streamlit/elements/widgets/time_widgets.py |
Core backend implementation with value parsing, validation, and widget registration |
lib/streamlit/__init__.py |
Exports datetime_input to public API |
lib/streamlit/testing/v1/element_tree.py |
AppTest support for DateTimeInput widget |
lib/streamlit/testing/v1/app_test.py |
Exposes datetime_input property in AppTest |
lib/tests/streamlit/typing/datetime_input_types.py |
Type checking tests for public API |
lib/tests/streamlit/elements/datetime_input_test.py |
Python unit tests for backend logic |
lib/tests/streamlit/element_mocks.py |
Test helper registration |
lib/tests/streamlit/delta_generator_test.py |
Duplicate widget ID test coverage |
frontend/lib/src/components/widgets/DateTimeInput/DateTimeInput.tsx |
React component implementation |
frontend/lib/src/components/widgets/DateTimeInput/DateTimeInput.test.tsx |
Frontend unit tests |
frontend/lib/src/components/widgets/DateTimeInput/index.ts |
Component export |
frontend/lib/src/components/core/Block/ElementNodeRenderer.tsx |
Renderer integration |
e2e_playwright/st_datetime_input.py |
Test application demonstrating widget features |
e2e_playwright/st_datetime_input_test.py |
E2E test suite |
e2e_playwright/shared/app_utils.py |
Test utility for locating datetime inputs |
e2e_playwright/__snapshots__/ |
Visual regression test snapshots (multiple PNG files) |
Collaborator
sfc-gh-bnisco
left a comment
sfc-gh-bnisco
left a comment
There was a problem hiding this comment.
Thanks for this PR! I've left some comments inline, let me know if you want to chat about any of them.
frontend/lib/src/components/widgets/DateTimeInput/DateTimeInput.tsx
Outdated
Show resolved
Hide resolved
frontend/lib/src/components/widgets/DateTimeInput/DateTimeInput.tsx
Outdated
Show resolved
Hide resolved
frontend/lib/src/components/widgets/DateTimeInput/DateTimeInput.tsx
Outdated
Show resolved
Hide resolved
frontend/lib/src/components/widgets/DateTimeInput/DateTimeInput.tsx
Outdated
Show resolved
Hide resolved
frontend/lib/src/components/widgets/DateTimeInput/DateTimeInput.tsx
Outdated
Show resolved
Hide resolved
frontend/lib/src/components/widgets/DateTimeInput/DateTimeInput.test.tsx
Outdated
Show resolved
Hide resolved
frontend/lib/src/components/widgets/DateTimeInput/DateTimeInput.test.tsx
Outdated
Show resolved
Hide resolved
frontend/lib/src/components/widgets/DateTimeInput/DateTimeInput.test.tsx
Outdated
Show resolved
Hide resolved
sfc-gh-aamadhavan
added
flaky-verify
sfc-gh-aamadhavan
force-pushed
the
aakarshm/date-time-input-1
branch
from
eb5f736 to
b8c0e10
Compare
Contributor
Author
Yeah it handles them the same way, basically strips the timezones (also documented) |
| """Test interactions with an empty datetime_input widget.""" | ||
|
|
||
| def script(): | ||
| import streamlit as st |
| def script(): | ||
| from datetime import datetime | ||
|
|
||
| import streamlit as st |
| def script(): | ||
| from datetime import datetime | ||
|
|
||
| import streamlit as st |
| def script(): | ||
| from datetime import datetime | ||
|
|
||
| import streamlit as st |
Collaborator
Time can apparently have a timezone attached to it (even though it's not very useful). @sfc-gh-aamadhavan can you check what |
Comment on lines
+1059
to
+1069
| if not isinstance(step, (int, timedelta)): | ||
| raise StreamlitAPIException( | ||
| f"`step` can only be `int` or `timedelta` but {type(step)} is provided." | ||
| ) | ||
| step_seconds = ( | ||
| int(step.total_seconds()) if isinstance(step, timedelta) else step | ||
| ) | ||
| if step_seconds < 60 or step_seconds > timedelta(hours=23).seconds: | ||
| raise StreamlitAPIException( | ||
| f"`step` must be between 60 seconds and 23 hours but is currently set to {step_seconds} seconds." | ||
| ) |
Contributor
There was a problem hiding this comment.
The step validation logic should include an explicit check for negative values. Currently, a negative step value could pass the validation if it's less than -timedelta(hours=23).seconds, which would create unexpected behavior. Consider adding a simple check like if step_seconds <= 0: before the existing range check to ensure only positive step values are accepted.
Suggested change
| if not isinstance(step, (int, timedelta)): | |
| raise StreamlitAPIException( | |
| f"`step` can only be `int` or `timedelta` but {type(step)} is provided." | |
| ) | |
| step_seconds = ( | |
| int(step.total_seconds()) if isinstance(step, timedelta) else step | |
| ) | |
| if step_seconds < 60 or step_seconds > timedelta(hours=23).seconds: | |
| raise StreamlitAPIException( | |
| f"`step` must be between 60 seconds and 23 hours but is currently set to {step_seconds} seconds." | |
| ) | |
| if not isinstance(step, (int, timedelta)): | |
| raise StreamlitAPIException( | |
| f"`step` can only be `int` or `timedelta` but {type(step)} is provided." | |
| ) | |
| step_seconds = ( | |
| int(step.total_seconds()) if isinstance(step, timedelta) else step | |
| ) | |
| if step_seconds <= 0: | |
| raise StreamlitAPIException( | |
| f"`step` must be a positive value but is currently set to {step_seconds} seconds." | |
| ) | |
| if step_seconds < 60 or step_seconds > timedelta(hours=23).seconds: | |
| raise StreamlitAPIException( | |
| f"`step` must be between 60 seconds and 23 hours but is currently set to {step_seconds} seconds." | |
| ) |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
| def script(): | ||
| from datetime import datetime | ||
|
|
||
| import streamlit as st |
Contributor
Author
Yeah I checked and replied above before about it, it is just ignored, which is the same behaviour as this. |
Collaborator
|
Ok great then good to go, thx for checking! |
sfc-gh-bnisco
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
st.datetime_input, including proto wiring, widget serde, AppTest bindings, and user-facing API.python scripts/update_e2e_snapshots.py --changedmake python-initScreenshot or video (only for visual changes)
DemoVideo.mov
GitHub Issue Link (if applicable)
Closes #6089
Testing Plan
Explanation of why no additional tests are needed
The feature ships with dedicated Python unit tests, typing checks, frontend unit tests, and comprehensive Playwright coverage, so no further manual tests are required.
Unit Tests (JS and/or Python)
PYTHONPATH=lib pytest lib/tests/streamlit/elements/datetime_input_test.pyyarn test lib/src/components/widgets/DateTimeInput/DateTimeInput.test.tsxE2E Tests
make run-e2e-test e2e_playwright/st_datetime_input_test.py(re-run after rebuilding the frontend)Any manual testing needed?
None beyond the automated suite.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.