[fix] st.dataframe date picker icon visibility in dark mode #12994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#12852) Fixes the calendar icon in `st.dataframe`'s date picker not being visible properly in dark mode. Applies theme-based filter correction to the WebKit calendar indicator. - Related to streamlit#12852 - Verified on light and dark themes. - Checked date/time/datetime-local inputs for better visibility in light and dark mode. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
lukasmasuch
approved these changes
Nov 11, 2025
Collaborator
lukasmasuch
left a comment
lukasmasuch
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for the contribution.
lukasmasuch
changed the title
lukasmasuch
added
security-assessment-completed
aritradhabal
deleted the
fix/st_dataframe_date_picker_icon_fix_in_dark_mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the calendar icon in
st.dataframe's date picker not being visible properly in dark mode. Applies theme-based filter correction to the WebKit calendar indicator.Closes In dark mode, datetime selector icon in
st.data_editoris also dark #12852Verified on light and dark themes.
Checked date/time/datetime-local inputs for better visibility in light and dark mode.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Describe your changes
Screenshot or video (only for visual changes)
Default.Behavior.mp4
Improved.mp4
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Note
Applies dark-theme conditional styling to WebKit calendar picker indicators in
StyledDataFrameOverlayto make date/time icons visible.frontend/lib/src/styled-components.ts:StyledDataFrameOverlayforinput[type='date'| 'time'| 'datetime-local']WebKit calendar picker indicator (filter: brightness(0) invert(1),opacity: 1).hasLightBackgroundColorto gate the styling by theme.Written by Cursor Bugbot for commit e9cf58b. This will update automatically on new commits. Configure here.