Skip to content

Show warning when hiding index in dynamic data editor #12978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukasmasuch merged 1 commit into from
Nov 11, 2025
Merged

Show warning when hiding index in dynamic data editor #12978

lukasmasuch merged 1 commit into from
Nov 11, 2025

Conversation

@lukasmasuch
Copy link
Collaborator

@lukasmasuch lukasmasuch commented Nov 8, 2025 •
edited by sfc-gh-lmasuch
Loading

Describe your changes

Logs a warning when the user tries to hide and index for a dataframe with a non-range index in data editor that is configured with num_rows="dynamic"

GitHub Issue Link (if applicable)

Testing Plan

  • Added unit test.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented Nov 8, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Licenses 0 0 0 0 0 issues
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2025 •
edited
Loading

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-12978/streamlit-1.51.0-py3-none-any.whl
📦 @streamlit/component-v2-lib Download from artifacts
🕹️ Preview app pr-12978.streamlit.app (☁️ Deploy here if not accessible)

@sfc-gh-lmasuch sfc-gh-lmasuch added security-assessment-completed Security assessment has been completed for PR change:feature PR contains new feature or enhancement implementation impact:users PR changes affect end users labels Nov 8, 2025
@sfc-gh-lmasuch sfc-gh-lmasuch marked this pull request as ready for review November 8, 2025 07:15
@lukasmasuch lukasmasuch merged commit 31dedf5 into develop Nov 11, 2025
50 of 51 checks passed
@lukasmasuch lukasmasuch deleted the show-warning-on-dynamic-data-editor branch November 11, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-bnisco sfc-gh-bnisco sfc-gh-bnisco approved these changes

Assignees

No one assigned

Labels

change:feature PR contains new feature or enhancement implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

st.data_editor hide_index=True is not hiding index column in version v1.30.0 and above when pd.DataFrame as input

4 participants

@lukasmasuch @sfc-gh-bnisco @sfc-gh-lmasuch