Merged
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
Collaborator
Author
|
Requires a new altair release: vega/altair#3895 |
sfc-gh-lmasuch
changed the title
Contributor
|
altair 6.0.0 Is now released with Python 3.14 support. |
lukasmasuch
added
security-assessment-completed
change:feature
lukasmasuch
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to add support for Python 3.14 to the Streamlit library. However, Python 3.14 has not been officially released yet (as of early 2025), making this change premature.
Key Changes:
- Updated Python version classifiers in setup.py to include 3.14
- Updated documentation and developer guidelines to reflect 3.10-3.14 support range
- Modified CI/CD configuration to include Python 3.14 in the test matrix
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/setup.py | Added Python 3.14 classifier to package metadata |
| lib/AGENTS.md | Updated supported Python versions documentation from 3.10-3.13 to 3.10-3.14 |
| .github/instructions/python.instructions.md | Updated supported Python versions in developer instructions |
| .github/actions/build_info/action.yml | Modified CI configuration to set max Python version to 3.14 and added 3.13 to test matrix |
| .github/ISSUE_TEMPLATE/bug_report.yml | Updated example Python version from 3.13 to 3.14 in bug report template |
| .cursor/rules/python.mdc | Updated supported Python versions in cursor rules documentation |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| assert sr6.selectbox[3].value == "Lisp" | ||
|
|
||
| with pytest.raises(ValueError, match="'invalid' is not in list"): | ||
| with pytest.raises(ValueError, match="not in list"): |
Collaborator
There was a problem hiding this comment.
[question] How is this related to python 3.14?
Collaborator
Author
There was a problem hiding this comment.
As far as I remember, this ValueError error message is triggered by python itself and something had slightly changed with the wording in 3.14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds official support for Python 3.14 and activates our CI to run with Python 3.14.
GitHub Issue Link (if applicable)
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.