[fix] st.color_picker minimum width constraint#12962
Merged
sfc-gh-lwilby merged 4 commits intodevelopfrom Nov 8, 2025
Merged
Conversation
sfc-gh-lwilby
added
security-assessment-completed
change:bugfix
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
sfc-gh-lwilby
changed the title
sfc-gh-lwilby
commented
Nov 7, 2025
Collaborator
Author
There was a problem hiding this comment.
I have a note to follow up on migrating this away from themed_app, but for this PR I am leaving it since the test has other snapshots as well.
sfc-gh-bnisco
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes color picker shrinking below its intrinsic size when
width < 40pxis specified.Changes Made:
minWidth: theme.sizes.minElementHeighttoStyledColorPickerto prevent container from shrinking below the 40x40px color blockGitHub Issue Link
Fixes #12872
Testing Plan
width=20case)Additional Notes:
The color block has a hard-coded width of
theme.sizes.minElementHeight(40px). Without a correspondingminWidthon the container, specifyingwidth < 40pxcaused the label to shrink while the color block stayed fixed, creating visual inconsistency.Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.