Skip to content

Fix MultiselectColumn issue when starting with empty rows #12935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukasmasuch merged 1 commit into from
Nov 5, 2025
Merged

Fix MultiselectColumn issue when starting with empty rows #12935

lukasmasuch merged 1 commit into from
Nov 5, 2025

Conversation

@lukasmasuch
Copy link
Collaborator

@lukasmasuch lukasmasuch commented Nov 5, 2025 •
edited by cursor bot
Loading

Describe your changes

Fix an issue with MultiselectColumn when starting from empty rows.

GitHub Issue Link (if applicable)

Testing Plan

  • Added unit test.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

Note

Treat ColumnDataKind.EMPTY like LIST in _parse_value, enabling list conversion for empty columns; add unit test coverage.

  • Data parsing:
    • Update _parse_value to handle ColumnDataKind.EMPTY like LIST, converting inputs to lists and adjusting the TypeError message accordingly.
  • Tests:
    • Add test case asserting list parsing for ColumnDataKind.EMPTY in data_editor_test.py.

Written by Cursor Bugbot for commit a8a46cb. This will update automatically on new commits. Configure here.

@snyk-io
Copy link
Contributor

snyk-io bot commented Nov 5, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@lukasmasuch lukasmasuch added security-assessment-completed Security assessment has been completed for PR change:bugfix PR contains bug fix implementation labels Nov 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025 •
edited
Loading

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-12935/streamlit-1.51.0-py3-none-any.whl
📦 @streamlit/component-v2-lib Download from artifacts
🕹️ Preview app pr-12935.streamlit.app (☁️ Deploy here if not accessible)

@lukasmasuch lukasmasuch added the impact:users PR changes affect end users label Nov 5, 2025
sfc-gh-lwilby
sfc-gh-lwilby approved these changes Nov 5, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-lwilby sfc-gh-lwilby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasmasuch lukasmasuch merged commit 25b46e6 into develop Nov 5, 2025
42 of 45 checks passed
@lukasmasuch lukasmasuch deleted the fix/multiselect-col-issue-with-empty-type branch November 5, 2025 19:27
@github-actions github-actions bot mentioned this pull request Dec 11, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-lwilby sfc-gh-lwilby sfc-gh-lwilby approved these changes

Assignees

No one assigned

Labels

change:bugfix PR contains bug fix implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

st.column_config.MultiselectColumn values are not saved when"data" is empty in data_editor

3 participants

@lukasmasuch @sfc-gh-lwilby