[test] Add e2e tests for JS in st.html #12919
Merged
+30
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This was referenced Nov 3, 2025
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
✅ PR preview is ready!
|
sfc-gh-bnisco
added
change:feature
Graphite App
sfc-gh-bnisco
added
the
impact:internal
Graphite App
sfc-gh-bnisco
removed
the
change:feature
sfc-gh-bnisco
added
the
change:chore
Graphite App
sfc-gh-bnisco
force-pushed
the
html-js-e2e
branch
from
6cda50f to
5a3b94a
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds E2E testing for JavaScript execution in st.html when the unsafe_allow_javascript=True parameter is enabled. This verifies the functionality of a security-sensitive feature that allows explicit JavaScript execution within HTML content.
- Adds a new test case to verify JavaScript executes when
unsafe_allow_javascript=Trueis set - Adds a new
st.htmlcall in the test app with JavaScript that modifies DOM and sets a global flag - Updates element count constants to reflect the additional HTML element
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| e2e_playwright/st_html.py | Adds a new st.html call with unsafe_allow_javascript=True containing JavaScript that modifies a div's text and sets a window variable |
| e2e_playwright/st_html_test.py | Adds test function to verify JavaScript execution, updates ST_HTML_ELEMENTS count from 10 to 11, and updates related assertions from 8 to 9 |
sfc-gh-bnisco
force-pushed
the
html-js-frontend
branch
from
e54803e to
461b031
Compare
sfc-gh-bnisco
force-pushed
the
html-js-e2e
branch
2 times, most recently
from
009f855 to
836c521
Compare
sfc-gh-bnisco
force-pushed
the
html-js-frontend
branch
from
461b031 to
0aefd4e
Compare
sfc-gh-lwilby
approved these changes
Nov 5, 2025
sfc-gh-bnisco
force-pushed
the
html-js-e2e
branch
from
836c521 to
18ce5b8
Compare
sfc-gh-bnisco
force-pushed
the
html-js-frontend
branch
from
0aefd4e to
a6334cb
Compare
sfc-gh-bnisco
force-pushed
the
html-js-e2e
branch
from
18ce5b8 to
f0aeb02
Compare
sfc-gh-bnisco
force-pushed
the
html-js-frontend
branch
from
a6334cb to
a806dd8
Compare
Collaborator
Author
Merge activity
|
sfc-gh-bnisco
changed the base branch from
html-js-frontend
to
graphite-base/12919
sfc-gh-bnisco
force-pushed
the
html-js-e2e
branch
from
f0aeb02 to
f52ae7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds e2e tests for
st.htmlwithunsafe_allow_javascript.GitHub Issue Link (if applicable)
Testing Plan
st_html.pythat includes JavaScript code with the new parameter, and updatedst_html_test.pyto verify that:Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.