[feat] Add Python API for st.html unsafe_allow_javascript #12917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
✅ PR preview is ready!
|
This was referenced Nov 3, 2025
sfc-gh-bnisco
added
change:feature
Graphite App
sfc-gh-bnisco
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new parameter unsafe_allow_javascript to the st.html API, allowing users to opt-in to executing JavaScript in HTML content. By default, JavaScript execution is disabled (False) for security reasons.
Key Changes:
- Added
unsafe_allow_javascriptboolean parameter to thehtml()method with default valueFalse - Updated documentation to reflect that JavaScript is now ignored by default and can be enabled via the new parameter
- The parameter is set on the protobuf message and passed through both standard and event container rendering paths
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/streamlit/elements/html.py | Added the unsafe_allow_javascript parameter to the html() method, updated docstring to document the new behavior, and set the parameter on the protobuf message |
| lib/tests/streamlit/elements/html_test.py | Added three unit tests covering default behavior (False), explicit True, and style-only HTML with the flag |
Comments suppressed due to low confidence (1)
lib/streamlit/elements/html.py:93
- The docstring is missing documentation for the new
unsafe_allow_javascriptparameter. According to Numpydoc style conventions, all parameters should be documented in the Parameters section.
width : "stretch", "content", or int
The width of the HTML element. This can be one of the following:
- ``"stretch"`` (default): The width of the element matches the
width of the parent container.
- ``"content"``: The width of the element matches the width of its
content, but doesn't exceed the width of the parent container.
- An integer specifying the width in pixels: The element has a
fixed width. If the specified width is greater than the width of
the parent container, the width of the element matches the width
of the parent container.
d6120c1 to
59e9e84
Compare
sfc-gh-bnisco
force-pushed
the
html-js-backend
branch
from
9ad33c4 to
0ade7e7
Compare
sfc-gh-bnisco
force-pushed
the
html-js-proto
branch
from
59e9e84 to
73ab06d
Compare
sfc-gh-bnisco
force-pushed
the
html-js-backend
branch
from
0ade7e7 to
d276838
Compare
sfc-gh-lwilby
approved these changes
Nov 6, 2025
sfc-gh-bnisco
force-pushed
the
html-js-backend
branch
from
d276838 to
89d39c5
Compare
Collaborator
Author
Merge activity
|
sfc-gh-bnisco
changed the base branch from
html-js-proto
to
graphite-base/12917
sfc-gh-bnisco
force-pushed
the
html-js-backend
branch
from
89d39c5 to
0dabd56
Compare
sfc-gh-dmatthews
added
impact:users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added a new
unsafe_allow_javascriptparameter tost.html()that allows JavaScript execution when set toTrue. By default, this parameter isFalse, maintaining the current behavior where JavaScript is ignored.Updated the docstring to clarify that JavaScript execution is now possible but disabled by default, with appropriate warnings about using this feature with caution.
GitHub Issue Link (if applicable)
Testing Plan
unsafe_allow_javascript=TrueContribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.