Skip to content

Conversation

@sfc-gh-lwilby
Copy link
Collaborator

@sfc-gh-lwilby sfc-gh-lwilby commented Oct 27, 2025

Describe your changes

This PR allows users to set content height on dataframes and data editors. Previously, height="auto" was limited to 10 rows and would scroll after that. To avoid performance issues from dataframes with extremely large numbers of rows, we still cap the height at ~285 rows (10,000px).

Screenshot 2025-10-27 at 8 41 29 PM

GitHub Issue Link (if applicable)

#12391

Testing Plan

  • Unit Tests (JS and/or Python) ✅
  • E2E Tests ✅

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented Oct 27, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-12875/streamlit-1.51.0-py3-none-any.whl
📦 @streamlit/component-v2-lib Download from artifacts
🕹️ Preview app pr-12875.streamlit.app (☁️ Deploy here if not accessible)

@sfc-gh-lwilby sfc-gh-lwilby added security-assessment-completed Security assessment has been completed for PR change:feature PR contains new feature or enhancement implementation impact:users PR changes affect end users labels Oct 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

📉 Frontend coverage change detected

The frontend unit test (vitest) coverage has decreased by 0.0300%

  • Current PR: 86.0000% (49871 lines, 6978 missed)
  • Latest develop: 86.0300% (49846 lines, 6963 missed)

💡 Consider adding more unit tests to maintain or improve coverage.

📊 View detailed coverage comparison

@sfc-gh-lwilby sfc-gh-lwilby changed the title adding content height option to dataframes and data editors [AdvancedLayouts] Add height="content" to st.dataframe and st.data_editor. Oct 27, 2025
@sfc-gh-lwilby sfc-gh-lwilby marked this pull request as ready for review October 27, 2025 21:31
@sfc-gh-lwilby sfc-gh-lwilby force-pushed the feature/add-height-content-dataframe-dataeditor branch from 40d9302 to 861ca8b Compare October 30, 2025 13:59
@sfc-gh-lwilby sfc-gh-lwilby merged commit a538b14 into develop Oct 30, 2025
38 checks passed
@sfc-gh-lwilby sfc-gh-lwilby deleted the feature/add-height-content-dataframe-dataeditor branch October 30, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:feature PR contains new feature or enhancement implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants