Make sure error message is explicitly shown for 500 errors#12845
Merged
Make sure error message is explicitly shown for 500 errors#12845
Conversation
kmcgrady
added
security-assessment-completed
change:bugfix
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the display of error messages when a 500 error occurs with an object response. Previously, object responses would be displayed as "[Object object]" in the error message. The fix stringifies object responses to show meaningful error information.
Key Changes:
- Modified error message formatting to wrap responses in markdown code blocks
- Added JSON stringification for object-type responses with pretty printing
- Added unit test coverage for the new object response handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/connection/src/DoInitPings.tsx | Updated error message formatting to stringify object responses and wrap all responses in markdown code blocks |
| frontend/connection/src/WebsocketConnection.test.tsx | Updated existing test assertion and added new test case for object response handling |
sfc-gh-bnisco
approved these changes
Oct 22, 2025
Collaborator
sfc-gh-bnisco
left a comment
sfc-gh-bnisco
left a comment
There was a problem hiding this comment.
+1 to the copilot suggestion, but LGTM overall
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
In the event of an 500 error on connection and the response is an object, we get the [Object object] error in the message. This change will JSON stringify it in the event we detect it's an object.
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.