Add SidebarConfigContext
#12791
Merged
Add SidebarConfigContext
#12791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
This was referenced Oct 16, 2025
Merged
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
mayagbarnes
added
security-assessment-completed
Graphite App
sfc-gh-mbarnes
force-pushed
the
navigation-sidebar-contexts
branch
from
fab04ec to
65881e8
Compare
sfc-gh-mbarnes
force-pushed
the
sidebar-config-context
branch
2 times, most recently
from
0c4918e to
f9d7623
Compare
sfc-gh-mbarnes
force-pushed
the
navigation-sidebar-contexts
branch
from
65881e8 to
49a5c47
Compare
sfc-gh-mbarnes
force-pushed
the
sidebar-config-context
branch
2 times, most recently
from
e43a48f to
a0bba88
Compare
sfc-gh-mbarnes
force-pushed
the
navigation-sidebar-contexts
branch
from
84d2d68 to
3d70b6e
Compare
mayagbarnes
changed the base branch from
navigation-sidebar-contexts
to
graphite-base/12791
sfc-gh-mbarnes
force-pushed
the
graphite-base/12791
branch
from
3d70b6e to
2bd1ffb
Compare
sfc-gh-mbarnes
force-pushed
the
sidebar-config-context
branch
from
a0bba88 to
2fe50da
Compare
mayagbarnes
changed the base branch from
graphite-base/12791
to
navigation-sidebar-contexts
Contributor
📈 Frontend coverage change detectedThe frontend unit test (vitest) coverage has increased by 0.0100%
✅ Coverage change is within normal range. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new SidebarConfigContext to improve context separation and organization in the Streamlit frontend architecture. The change moves sidebar-related configuration properties (initialSidebarState, appLogo, sidebarChevronDownshift, expandSidebarNav, hideSidebarNav) from AppContext to a dedicated SidebarConfigContext.
Key changes:
- Created new
SidebarConfigContextwith comprehensive documentation - Updated all components to consume sidebar config from the new context
- Refactored test utilities to support the new context provider
- Removed
appLogoprop drilling through component trees
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/lib/src/components/core/SidebarConfigContext.tsx | New context file defining sidebar configuration properties |
| frontend/lib/src/index.ts | Exports new SidebarConfigContext and types |
| frontend/app/src/components/StreamlitContextProvider.tsx | Integrates SidebarConfigContext into provider hierarchy |
| frontend/app/src/components/AppContext.tsx | Removes sidebar-related properties |
| frontend/app/src/components/AppView/AppView.tsx | Consumes sidebar config from new context instead of props/AppContext |
| frontend/app/src/components/Sidebar/Sidebar.tsx | Uses SidebarConfigContext instead of AppContext for sidebar properties |
| frontend/app/src/components/Navigation/SidebarNav.tsx | Switches from AppContext to SidebarConfigContext |
| frontend/lib/src/test_util.tsx | Adds SidebarConfigContext support to test rendering utilities |
| frontend/app/src/components/AppView/AppView.test.tsx | Updates tests to use new context structure |
| frontend/app/src/components/Sidebar/Sidebar.test.tsx | Refactors tests to provide SidebarConfigContext |
| frontend/app/src/components/Navigation/SidebarNav.test.tsx | Updates test helpers to use SidebarConfigContext |
| frontend/app/src/App.tsx | Removes appLogo prop from AppView |
| Multiple test files | Adds empty SidebarConfigContext overrides to maintain test compatibility |
sfc-gh-mbarnes
force-pushed
the
navigation-sidebar-contexts
branch
from
2bd1ffb to
ac1148f
Compare
sfc-gh-mbarnes
force-pushed
the
sidebar-config-context
branch
from
92b57cd to
61e36b8
Compare
sfc-gh-mbarnes
force-pushed
the
navigation-sidebar-contexts
branch
from
ac1148f to
4ba6af1
Compare
sfc-gh-mbarnes
force-pushed
the
sidebar-config-context
branch
from
61e36b8 to
67acfad
Compare
sfc-gh-bnisco
approved these changes
Oct 29, 2025
sfc-gh-mbarnes
force-pushed
the
sidebar-config-context
branch
from
67acfad to
bc6f5f4
Compare
sfc-gh-mbarnes
force-pushed
the
navigation-sidebar-contexts
branch
from
4ba6af1 to
352b359
Compare
sfc-gh-mbarnes
force-pushed
the
sidebar-config-context
branch
from
bc6f5f4 to
e2ec103
Compare
sfc-gh-mbarnes
force-pushed
the
navigation-sidebar-contexts
branch
from
352b359 to
1985977
Compare
sfc-gh-mbarnes
force-pushed
the
sidebar-config-context
branch
from
e2ec103 to
2b0aa23
Compare
This was referenced Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Part 4 of
StreamlitContextProviderupdatesAdds new
SidebarConfigContextwith the following:initialSidebarStateappLogosidebarChevronDownshiftexpandSidebarNavhideSidebarNavTesting Plan