Add ScriptRunContext & ThemeContext
#12789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
✅ PR preview is ready!
|
This was referenced Oct 16, 2025
Merged
Merged
mayagbarnes
added
security-assessment-completed
sfc-gh-mbarnes
force-pushed
the
forms-context-fix
branch
from
8542499 to
b8a25c9
Compare
sfc-gh-mbarnes
force-pushed
the
script-theme-context
branch
from
0f4bc7a to
62b6dc4
Compare
sfc-gh-mbarnes
force-pushed
the
forms-context-fix
branch
from
62224e6 to
46085a1
Compare
sfc-gh-mbarnes
force-pushed
the
script-theme-context
branch
from
62b6dc4 to
9ee3f05
Compare
sfc-gh-mbarnes
force-pushed
the
forms-context-fix
branch
from
46085a1 to
bd2f963
Compare
sfc-gh-mbarnes
force-pushed
the
script-theme-context
branch
from
9ee3f05 to
0a8b7fa
Compare
Contributor
📈 Frontend coverage change detectedThe frontend unit test (vitest) coverage has increased by 0.0200%
✅ Coverage change is within normal range. |
sfc-gh-mbarnes
force-pushed
the
script-theme-context
branch
from
46ed607 to
e0e69c0
Compare
sfc-gh-mbarnes
force-pushed
the
forms-context-fix
branch
from
bd2f963 to
8f45c0a
Compare
sfc-gh-mbarnes
force-pushed
the
script-theme-context
branch
from
e0e69c0 to
51c39dc
Compare
sfc-gh-mbarnes
force-pushed
the
forms-context-fix
branch
from
8f45c0a to
5c4a28d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the context provider architecture by extracting theme-related and script run-related properties from LibContext into two new specialized contexts: ThemeContext and ScriptRunContext. This separation improves performance by allowing components to subscribe only to the context values they actually need, reducing unnecessary re-renders.
Key Changes
- Created
ThemeContextwith theme management properties (activeTheme,setTheme,availableThemes) - Created
ScriptRunContextwith script execution state properties (scriptRunState,scriptRunId,fragmentIdsThisRun) - Updated
LibContextto remove the migrated properties - Updated all consuming components to use the appropriate new contexts
- Modified test utilities to support the new context structure with proper nesting order
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
frontend/lib/src/components/core/ThemeContext.tsx |
New context for theme configuration and management |
frontend/lib/src/components/core/ScriptRunContext.tsx |
New context for script execution state |
frontend/lib/src/components/core/LibContext.tsx |
Removed theme and script run properties |
frontend/lib/src/test_util.tsx |
Updated test utilities to support new contexts with proper nesting order |
frontend/lib/src/index.ts |
Exported new contexts and their types |
frontend/app/src/components/StreamlitContextProvider.tsx |
Integrated new contexts into provider hierarchy |
frontend/app/src/util/useThemeManager.ts |
Improved theme update logic with functional state update |
frontend/app/src/hooks/useViewportSize.ts |
Updated to consume ThemeContext instead of LibContext |
frontend/app/src/components/Sidebar/ThemedSidebar.tsx |
Updated to consume ThemeContext instead of LibContext |
frontend/app/src/components/Header/Header.tsx |
Updated to consume ThemeContext instead of LibContext |
frontend/app/src/components/AppView/AppView.tsx |
Updated to consume ThemeContext instead of LibContext |
frontend/app/src/components/StreamlitDialog/SettingsDialog.tsx |
Updated to consume ThemeContext instead of LibContext |
frontend/lib/src/components/widgets/Form/Form.tsx |
Updated to consume ScriptRunContext instead of LibContext |
frontend/lib/src/components/elements/Tabs/Tabs.tsx |
Updated to consume ScriptRunContext instead of LibContext |
frontend/lib/src/components/core/Block/Block.tsx |
Updated to consume ScriptRunContext instead of LibContext |
frontend/lib/src/components/core/Block/ElementNodeRenderer.tsx |
Updated to consume ScriptRunContext instead of LibContext |
| Multiple test files | Updated test cases to provide new context overrides in correct nesting order |
sfc-gh-mbarnes
force-pushed
the
forms-context-fix
branch
from
5c4a28d to
91407b6
Compare
sfc-gh-mbarnes
force-pushed
the
script-theme-context
branch
from
51c39dc to
82c26a7
Compare
sfc-gh-mbarnes
force-pushed
the
script-theme-context
branch
from
82c26a7 to
4b7aa49
Compare
sfc-gh-mbarnes
force-pushed
the
forms-context-fix
branch
from
91407b6 to
f1c3295
Compare
sfc-gh-mbarnes
force-pushed
the
forms-context-fix
branch
from
f1c3295 to
f1903ca
Compare
sfc-gh-mbarnes
force-pushed
the
script-theme-context
branch
from
4b7aa49 to
18e4daf
Compare
sfc-gh-bnisco
approved these changes
Oct 29, 2025
sfc-gh-mbarnes
force-pushed
the
forms-context-fix
branch
from
f1903ca to
751c098
Compare
sfc-gh-mbarnes
force-pushed
the
script-theme-context
branch
from
18e4daf to
d7551c7
Compare
This was referenced Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Part 2 of
StreamlitContextProviderupdatesAdds new
ScriptRunContextwith the following:scriptRunStatescriptRunIdfragmentIdsThisRunAdds new
ThemeContextwith the following:activeThemesetThemeavailableThemesTesting Plan