Update FormsContext
#12788
Merged
Update FormsContext
#12788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 16, 2025
Merged
mayagbarnes
added
security-assessment-completed
sfc-gh-mbarnes
force-pushed
the
forms-context-fix
branch
4 times, most recently
from
bd2f963 to
8f45c0a
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves the consumption of formsData from Block.tsx down to the Form component, improving rendering performance by ensuring only Form components re-render when form data changes. It also removes addScriptFinishedHandler and removeScriptFinishedHandler from LibContext since these are only used in AppView. Additionally, the renderWithContexts test utility is enhanced to support updating context values during re-renders.
Key Changes:
- Moved
formsDataconsumption fromBlock.tsxtoForm.tsxfor better performance - Removed script finished handler methods from
LibContext - Enhanced
renderWithContextsto return arerenderWithContextsfunction for more flexible testing
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
frontend/lib/src/test_util.tsx |
Added RenderWithContextsResult interface and rerenderWithContexts function to support context updates during re-renders |
frontend/lib/src/components/widgets/Form/Form.tsx |
Moved formsData and scriptRunState consumption into Form component, removing props dependencies |
frontend/lib/src/components/widgets/Form/Form.test.tsx |
Updated tests to use new context-based approach with rerenderWithContexts |
frontend/lib/src/hooks/useWidgetManagerElementState.test.tsx |
Updated test to use renderWithContexts and provide formsData via context |
frontend/lib/src/components/core/Block/Block.tsx |
Removed formsData consumption and form-related prop calculations |
frontend/lib/src/components/core/LibContext.tsx |
Removed addScriptFinishedHandler and removeScriptFinishedHandler from context interface |
frontend/lib/src/components/core/FormsContext.tsx |
Updated documentation comments and fixed typo |
frontend/app/src/components/StreamlitContextProvider.tsx |
Removed script finished handler props from provider |
frontend/app/src/components/AppView/AppView.tsx |
Added script finished handlers as direct props instead of from context |
frontend/app/src/components/AppView/AppView.test.tsx |
Added mock handlers to test props |
frontend/app/src/App.tsx |
Moved script finished handlers from context to AppView props |
sfc-gh-mbarnes
force-pushed
the
forms-context-fix
branch
2 times, most recently
from
5c4a28d to
91407b6
Compare
sfc-gh-mbarnes
force-pushed
the
forms-context-fix
branch
from
91407b6 to
f1c3295
Compare
sfc-gh-bnisco
approved these changes
Oct 29, 2025
Collaborator
sfc-gh-bnisco
left a comment
sfc-gh-bnisco
left a comment
There was a problem hiding this comment.
Looks like there's a merge conflict with Block, but should be good to go afterwards!
sfc-gh-mbarnes
force-pushed
the
forms-context-fix
branch
from
f1c3295 to
f1903ca
Compare
sfc-gh-mbarnes
force-pushed
the
forms-context-fix
branch
from
f1903ca to
751c098
Compare
This was referenced Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Part 1 of
StreamlitContextProviderupdatesformsDatafromBlock.tsxrenderWithContextfunction to return arerenderWithContextsfunction to allow for changes in context values on rerender for more testing flexibilityRemoves
addScriptFinishedHandler&removeScriptFinishedHandlerfrom context as these are used one level down inAppViewcomponent.Testing Plan