[feat] Add rendering logic for st.space elements in frontend.#12735
Merged
sfc-gh-lwilby merged 1 commit intodevelopfrom Oct 11, 2025
Merged
[feat] Add rendering logic for st.space elements in frontend.#12735sfc-gh-lwilby merged 1 commit intodevelopfrom
st.space elements in frontend.#12735sfc-gh-lwilby merged 1 commit intodevelopfrom
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Collaborator
Author
This was referenced Oct 9, 2025
Contributor
✅ PR preview is ready!
|
sfc-gh-lwilby
changed the title
st.space elements in frontend.
sfc-gh-lwilby
added
security-assessment-completed
impact:internal
sfc-gh-lwilby
force-pushed
the
10-09-st-space-frontend-rendering
branch
from
2c6f33a to
e9b913d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds frontend rendering support for st.space elements by implementing the necessary React component and styling. The change enables the frontend to properly display space elements that are created using Streamlit's st.space API.
- Adds a new styled component
StyledSpacefor rendering space elements - Implements the "space" case in the element renderer switch statement
- Includes proper CSS class and test ID attributes for styling and testing
lukasmasuch
approved these changes
Oct 9, 2025
Collaborator
lukasmasuch
left a comment
lukasmasuch
left a comment
There was a problem hiding this comment.
LGTM 👍 but it might be good to move it to styled-components.ts
Comment on lines
+177
to
+182
| const StyledSpace = styled.div({ | ||
| // Styling is handled in StyledElementContainerLayoutWrapper. | ||
| // Space component should fill the container. | ||
| width: "100%", | ||
| height: "100%", | ||
| }) |
Collaborator
There was a problem hiding this comment.
since this is a styled component it might be better to move it to styled-components.ts
sfc-gh-lwilby
force-pushed
the
10-09-st-space-style-customization-meet-space-requirements
branch
from
da2b27f to
b012240
Compare
sfc-gh-lwilby
force-pushed
the
10-09-st-space-frontend-rendering
branch
from
e9b913d to
6fd43aa
Compare
Contributor
📉 Frontend coverage change detectedThe frontend unit test (vitest) coverage has decreased by 0.0000%
✅ Coverage change is within normal range. |
sfc-gh-lwilby
force-pushed
the
10-09-st-space-frontend-rendering
branch
from
6fd43aa to
9b066d1
Compare
sfc-gh-lwilby
force-pushed
the
10-09-st-space-style-customization-meet-space-requirements
branch
from
b012240 to
9853884
Compare
sfc-gh-lwilby
force-pushed
the
10-09-st-space-frontend-rendering
branch
2 times, most recently
from
0999747 to
f1606bc
Compare
sfc-gh-lwilby
force-pushed
the
10-09-st-space-style-customization-meet-space-requirements
branch
from
9853884 to
3d732cd
Compare
Base automatically changed from
10-09-st-space-style-customization-meet-space-requirements
to
develop
October 11, 2025 06:59
sfc-gh-lwilby
force-pushed
the
10-09-st-space-frontend-rendering
branch
from
f1606bc to
3622f59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Rendering for
st.spacetype elements in the frontend.GitHub Issue Link (if applicable)
Testing Plan
E2E tests will cover this in last PR.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.