[feat] Styling customizations for st.space#12734
Merged
sfc-gh-lwilby merged 1 commit intodevelopfrom Oct 11, 2025
Merged
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Collaborator
Author
This was referenced Oct 9, 2025
Contributor
✅ PR preview is ready!
|
This was referenced Oct 9, 2025
sfc-gh-lwilby
changed the title
st.space
sfc-gh-lwilby
added
security-assessment-completed
impact:internal
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements styling customizations specifically for st.space elements to ensure they only affect spacing in the intended direction based on their parent container's layout orientation.
- Adds minimal cross-axis dimensions (minWidth: 0, minHeight: 0) for space elements
- Implements direction-aware styling logic that sets width for horizontal layouts and height for vertical layouts
- Prevents unintended cross-axis spacing by clearing the non-primary dimension
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/lib/src/components/core/Block/styled-components.ts | Adds minimal cross-axis dimensions for space elements to prevent unwanted spacing |
| frontend/lib/src/components/core/Block/StyledElementContainerLayoutWrapper.tsx | Implements direction-aware styling that applies only the relevant dimension based on layout orientation |
frontend/lib/src/components/core/Block/StyledElementContainerLayoutWrapper.tsx
Show resolved
Hide resolved
frontend/lib/src/components/core/Block/StyledElementContainerLayoutWrapper.tsx
Show resolved
Hide resolved
sfc-gh-bnisco
approved these changes
Oct 9, 2025
sfc-gh-lwilby
changed the base branch from
10-09-st-space-update-uselayoutstyles-support-rem
to
graphite-base/12734
sfc-gh-lwilby
force-pushed
the
graphite-base/12734
branch
from
d616f7a to
928bdf6
Compare
sfc-gh-lwilby
force-pushed
the
10-09-st-space-style-customization-meet-space-requirements
branch
from
da2b27f to
b012240
Compare
sfc-gh-lwilby
changed the base branch from
graphite-base/12734
to
10-09-st-space-update-uselayoutstyles-support-rem
Contributor
📉 Frontend coverage change detectedThe frontend unit test (vitest) coverage has decreased by 0.0400%
💡 Consider adding more unit tests to maintain or improve coverage. |
sfc-gh-lwilby
force-pushed
the
10-09-st-space-update-uselayoutstyles-support-rem
branch
from
928bdf6 to
ee4f058
Compare
sfc-gh-lwilby
force-pushed
the
10-09-st-space-style-customization-meet-space-requirements
branch
from
b012240 to
9853884
Compare
Base automatically changed from
10-09-st-space-update-uselayoutstyles-support-rem
to
develop
October 10, 2025 18:20
sfc-gh-lwilby
force-pushed
the
10-09-st-space-style-customization-meet-space-requirements
branch
from
9853884 to
3d732cd
Compare
sfc-gh-lwilby
deleted the
10-09-st-space-style-customization-meet-space-requirements
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
st.spacehas some unique requirements. The element should have only width or height depending on the direction of the parent container (vertical = height, horizontal = width).GitHub Issue Link (if applicable)
Testing Plan
E2E tests cover this in later PRs.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.