Skip to content

[feat] Proto changes for st.space#12732

Merged
sfc-gh-lwilby merged 1 commit intodevelopfrom
10-07-st-space-proto-files
Oct 10, 2025
Merged

[feat] Proto changes for st.space#12732
sfc-gh-lwilby merged 1 commit intodevelopfrom
10-07-st-space-proto-files

Conversation

@sfc-gh-lwilby
Copy link
Copy Markdown
Collaborator

@sfc-gh-lwilby sfc-gh-lwilby commented Oct 9, 2025

Describe your changes

Adds new proto definitions to support the st.space element.

GitHub Issue Link (if applicable)

Testing Plan

Proto only. Tests in later PRs.


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Copy Markdown
Contributor

snyk-io bot commented Oct 9, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2025

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-12732/streamlit-1.50.0-py3-none-any.whl
📦 @streamlit/component-v2-lib Download from artifacts
🕹️ Preview app pr-12732.streamlit.app (☁️ Deploy here if not accessible)

@sfc-gh-lwilby sfc-gh-lwilby added security-assessment-completed impact:internal PR changes only affect internal code change:feature PR contains new feature or enhancement implementation labels Oct 9, 2025
@sfc-gh-lwilby sfc-gh-lwilby changed the title st-space-proto-files [feat] Proto changes for st.space Oct 9, 2025
@sfc-gh-lwilby sfc-gh-lwilby marked this pull request as ready for review October 9, 2025 13:02
@sfc-gh-lwilby sfc-gh-lwilby requested a review from a team as a code owner October 9, 2025 13:02
@lukasmasuch lukasmasuch requested a review from Copilot October 9, 2025 18:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds protocol buffer definitions to support a new st.space element in Streamlit, which will provide vertical and horizontal spacing capabilities for layout control.

Key changes:

  • Introduces a new Space.proto message for the spacing element
  • Extends WidthConfig and HeightConfig with rem unit support
  • Integrates the Space element into the main Element proto definition

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
proto/streamlit/proto/Space.proto New proto definition for the Space element with documentation
proto/streamlit/proto/WidthConfig.proto Adds rem_width field for relative unit sizing
proto/streamlit/proto/HeightConfig.proto Adds rem_height field for relative unit sizing
proto/streamlit/proto/Element.proto Imports Space proto and adds it to the element union with updated field numbering

Copy link
Copy Markdown
Collaborator

@lukasmasuch lukasmasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfc-gh-lwilby sfc-gh-lwilby merged commit bb4d108 into develop Oct 10, 2025
44 of 45 checks passed
@sfc-gh-lwilby sfc-gh-lwilby deleted the 10-07-st-space-proto-files branch October 10, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:feature PR contains new feature or enhancement implementation impact:internal PR changes only affect internal code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants