Patching WT_SESSION so that Credentails test does not fail on Windows…#12652
Merged
lukasmasuch merged 4 commits intostreamlit:developfrom Oct 8, 2025
Merged
Patching WT_SESSION so that Credentails test does not fail on Windows…#12652lukasmasuch merged 4 commits intostreamlit:developfrom
lukasmasuch merged 4 commits intostreamlit:developfrom
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a failing test on Windows WSL2 by patching the WT_SESSION environment variable to ensure emoji display behavior is correctly tested. The test was failing because Windows Terminal sets WT_SESSION to a truthy value, which affects the emoji display logic in the credentials module.
Key changes:
- Added environment variable patch to ensure consistent test behavior across different Windows environments
lukasmasuch
added
security-assessment-completed
change:other
lukasmasuch
approved these changes
Oct 8, 2025
Collaborator
lukasmasuch
left a comment
lukasmasuch
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… Terminal
Describe your changes
When running tests with
make python-teston Winows WSL2, the following test fails because WT_SESSION is truthy;FAILED tests/streamlit/runtime/credentials_test.py::CredentialsModulesTest::test_show_emojis_windows - AssertionError: assert '👋' not in '\n 👋 \...ail: \x1b[0m'I have added patch for WT_SESSION env var so that that it is falsey when running the credential test on Windows Terminal
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.