[AdvancedLayouts] Modernize height parameter for st.pydeck_chart#12613
Merged
sfc-gh-lwilby merged 9 commits intodevelopfrom Sep 26, 2025
Merged
[AdvancedLayouts] Modernize height parameter for st.pydeck_chart#12613sfc-gh-lwilby merged 9 commits intodevelopfrom
sfc-gh-lwilby merged 9 commits intodevelopfrom
Conversation
- Updated parameter signature from height: int | None = None to height: HeightWithoutContent = 500 - Removed height prop from frontend DeckGL and StaticMap components (now uses CSS-based height) - Updated styled component to use height: 100% with minHeight: 6.25rem - Added comprehensive E2E tests for height parameter behavior (height=500, height="stretch") - Added unit tests for height validation and default value - Preserves backward compatibility for existing integer height values
sfc-gh-lwilby
added
security-assessment-completed
change:feature
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
sfc-gh-lwilby
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
sfc-gh-bnisco
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Modernizes
st.pydeck_chartheight parameter to use the newHeighttype system ("stretch"or pixel values) for consistency with other chart elements.Changes Made:
height: int | None = Nonetoheight: HeightWithoutContent = 500height: 100%, minHeight: 6.25rem)GitHub Issue Link (if applicable)
Testing Plan
Screenshots/Demos:
(E2E test snapshots show visual differences for height="stretch" and height=500)
Additional Notes:
This follows the established pattern from other chart elements. Part of the broader AdvancedLayouts initiative to provide consistent height APIs across all chart elements.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.