Add type argument to st.popover to match st.button#12598
Merged
sfc-gh-tteixeira merged 4 commits intodevelopfrom Sep 22, 2025
Merged
Add type argument to st.popover to match st.button#12598sfc-gh-tteixeira merged 4 commits intodevelopfrom
type argument to st.popover to match st.button#12598sfc-gh-tteixeira merged 4 commits intodevelopfrom
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
| self, | ||
| label: str, | ||
| *, | ||
| type: Literal["primary", "secondary", "tertiary"] = "secondary", |
Contributor
There was a problem hiding this comment.
The type parameter already includes the correct type annotation Literal["primary", "secondary", "tertiary"] with default value "secondary". The comment appears to be incorrect as the type annotation is present in the code.
Spotted by Diamond (based on custom rule: Python Guide)
Is this helpful? React 👍 or 👎 to let us know.
Collaborator
|
Love it, go ahead! (Look who filed #10416 😉 ) |
sfc-gh-bnisco
approved these changes
Sep 22, 2025
sfc-gh-bnisco
added
security-assessment-completed
change:feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The
st.popovercommand currently inserts a button in your app which shows a popover when clicked. However, unlike a regularst.button, that button cannot be styled as primary/secondary/tertiary.This PR fixes that. This adds
type="primary"|"secondary"|"tertiary"tost.popover.GitHub Issue Link (if applicable)
Closes #10416
Testing Plan
Explanation of why no additional tests are neededAny manual testing needed?Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.