Update vega_lite_chart width parameter default handling for type consistency#12595
Merged
sfc-gh-lwilby merged 1 commit intodevelopfrom Sep 23, 2025
Merged
Conversation
- Change width parameter from Width = 'stretch' to Width | None = None - Allows internal logic to determine appropriate default based on chart type - Add test to verify default width parameter behavior and consistency - Ensures type consistency between overloads and implementation
sfc-gh-lwilby
added
security-assessment-completed
impact:internal
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
sfc-gh-lwilby
changed the title
sfc-gh-lwilby
added
impact:users
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
sfc-gh-bnisco
approved these changes
Sep 22, 2025
sfc-gh-lwilby
deleted the
feature/vega-lite-default-width-consistency
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updates
st.vega_lite_chartwidth parameter default handling to improve type consistency between function overloads and implementation.Changes Made:
width: Width = "stretch"towidth: Width | None = Nonein both overloadsKey Implementation Details:
GitHub Issue Link (if applicable)
Testing Plan
Additional Notes:
This change improves type consistency in the
vega_lite_chartfunction signatures while maintaining full backward compatibility. The modification allows for more flexible internal default handling without changing any user-facing behavior.Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.