[AdvancedLayouts] Add height to st.plotly_chart #12593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-lwilby
added
security-assessment-completed
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
sfc-gh-lwilby
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
sfc-gh-lwilby
force-pushed
the
feature/add-height-to-plotly-charts
branch
from
9b9cc6b to
0d3bb6c
Compare
sfc-gh-lwilby
commented
Sep 22, 2025
Collaborator
Author
There was a problem hiding this comment.
I can't reproduce this change locally in chrome, firefox or safari, but it seems persistent in CI. With that in mind, it seems likely a minor impact to users if it is reproducible outside of CI.
sfc-gh-lwilby
changed the title
sfc-gh-lwilby
force-pushed
the
feature/add-height-to-plotly-charts
branch
from
0a8bff4 to
d6b0dce
Compare
Contributor
📉 Frontend coverage change detectedThe frontend unit test (vitest) coverage has decreased by 0.0200%
✅ Coverage change is within normal range. |
sfc-gh-lwilby
force-pushed
the
feature/add-height-to-plotly-charts
branch
from
69f6ebc to
1c0aef3
Compare
sfc-gh-lwilby
force-pushed
the
feature/add-height-to-plotly-charts
branch
from
1c0aef3 to
4e24a57
Compare
sfc-gh-lwilby
commented
Oct 23, 2025
| ) | ||
| st.plotly_chart(fig, theme="streamlit") | ||
|
|
||
| # Width parameter tests |
Collaborator
Author
There was a problem hiding this comment.
I had to split up these tests because otherwise the tests were timing out consistently in CI.
mayagbarnes
reviewed
Oct 29, 2025
Collaborator
There was a problem hiding this comment.
Question: This change seems a little strange to me - any idea why the movement in the time selection buttons?
Collaborator
There was a problem hiding this comment.
Nvm - just noticed your comment above
mayagbarnes
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a new
heightparameter tost.plotly_chartusing theHeighttype system ("stretch","content", or pixel values) for consistency with other chart elements.Changes Made:
height: Height = "stretch"parameterheight="content", respects plotly.Figure's native height if specifiedKey Implementation Details:
Height Parameter Addition:
heightparameter with defaultheight="stretch"height="content"extracts height from native chart object if available, falls back to"stretch"GitHub Issue Link (if applicable)
Testing Plan
Screenshots/Demos:
Additional Notes:
This extends the AdvancedLayouts initiative by adding height support to
st.plotly_chart, bringing it in line with other chart elements that support theHeighttype system.Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.