Make slider thumbs not overshoot the track#12549
Merged
sfc-gh-tteixeira merged 19 commits intodevelopfrom Sep 18, 2025
Merged
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sfc-gh-tteixeira
changed the title
Contributor
✅ PR preview is ready!
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes slider thumbs overshooting their track boundaries by implementing a new DOM structure where thumbs are positioned within a wrapper container that has proper horizontal padding, while the track itself remains unpadded.
Key changes:
- Introduces a custom
renderInnerTrackfunction to restructure the slider's DOM hierarchy - Adds new styled components (
StyledInnerTrackWrapperandStyledThumbWrapper) to control thumb positioning - Updates transition timing for slider tick bar visibility
Reviewed Changes
Copilot reviewed 3 out of 117 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
frontend/lib/src/components/widgets/Slider/styled-components.ts |
Adds new styled components for track wrapper and thumb positioning, updates tick bar transition |
frontend/lib/src/components/widgets/Slider/Slider.tsx |
Implements custom inner track rendering logic and restructures slider DOM hierarchy |
e2e_playwright/st_slider.py |
Updates test values to reflect corrected slider behavior |
lukasmasuch
approved these changes
Sep 18, 2025
Collaborator
lukasmasuch
left a comment
lukasmasuch
left a comment
There was a problem hiding this comment.
LGTM 👍 just needs a e2e snapshot update
lukasmasuch
added
security-assessment-completed
change:bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Make slider thumbs not overshoot the track. (I found a really nice way of doing this!)
Also: this improves the animation for showing the min/max labels, and makes them show on focus-visible as well for better a11y.
GitHub Issue Link (if applicable)
Closes #4284
Testing Plan
Explanation of why no additional tests are neededAny manual testing needed?Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.