[test] Simplify st.audio_input test app#12541
Merged
sfc-gh-nbellante merged 2 commits intographite-base/12541from Sep 22, 2025
Merged
[test] Simplify st.audio_input test app#12541sfc-gh-nbellante merged 2 commits intographite-base/12541from
st.audio_input test app#12541sfc-gh-nbellante merged 2 commits intographite-base/12541from
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 16, 2025
sfc-gh-nbellante
added
security-assessment-completed
impact:internal
Contributor
📉 Frontend coverage change detectedThe frontend unit test (vitest) coverage has decreased by 0.0300%
💡 Consider adding more unit tests to maintain or improve coverage. |
sfc-gh-nbellante
changed the base branch from
remove-problematic-waits
to
graphite-base/12541
sfc-gh-nbellante
force-pushed
the
simplify-test-app
branch
from
643ad26 to
93d9ce8
Compare
sfc-gh-nbellante
force-pushed
the
graphite-base/12541
branch
from
63e48bf to
31a610e
Compare
sfc-gh-nbellante
changed the base branch from
graphite-base/12541
to
remove-problematic-waits
sfc-gh-nbellante
changed the title
sfc-gh-nbellante
changed the title
st.audio_input test app
sfc-gh-nbellante
force-pushed
the
simplify-test-app
branch
from
9ede320 to
62f76d0
Compare
This was referenced Sep 18, 2025
sfc-gh-nbellante
force-pushed
the
simplify-test-app
branch
from
62f76d0 to
4cc7ac9
Compare
sfc-gh-nbellante
force-pushed
the
remove-problematic-waits
branch
2 times, most recently
from
0e0fb7d to
8f07a70
Compare
sfc-gh-nbellante
force-pushed
the
simplify-test-app
branch
2 times, most recently
from
d4b6e04 to
018ba0b
Compare
Remove redundant and over-engineered features while keeping essential test coverage: - Removed duplicate WAV analysis displays - Removed verbose function wrappers - Kept essential test scenarios: forms, fragments, callbacks, remount, sample rates - Maintained all critical test assertions
sfc-gh-nbellante
force-pushed
the
simplify-test-app
branch
from
018ba0b to
8cf88ab
Compare
sfc-gh-nbellante
force-pushed
the
remove-problematic-waits
branch
from
8f07a70 to
71fe8f0
Compare
sfc-gh-nbellante
changed the base branch from
remove-problematic-waits
to
graphite-base/12541
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+66
to
+67
| def on_change(): | ||
| st.session_state.audio_input_changed = True |
Contributor
There was a problem hiding this comment.
The on_change function lacks a docstring. Python Guide docstring requirements mandate Numpydoc style docstrings for functions. Since this callback function is used with st.audio_input and may be accessed by users, add a docstring explaining its purpose:
def on_change():
"""Callback function to set a flag when audio input changes."""
st.session_state.audio_input_changed = True
Suggested change
| def on_change(): | |
| st.session_state.audio_input_changed = True | |
| def on_change(): | |
| """Callback function to set a flag when audio input changes.""" | |
| st.session_state.audio_input_changed = True | |
Spotted by Diamond (based on custom rule: Python Guide)
Is this helpful? React 👍 or 👎 to let us know.
sfc-gh-bnisco
approved these changes
Sep 19, 2025
sfc-gh-nbellante
merged this pull request
into
graphite-base/12541
68 of 82 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR focuses on cleaning up the test streamlit app for st.audio_input to be more straightforward and easier to maintain.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.