[test] Remove problematic 5000ms wait in the e2e's st_audio_input stop_recording#12540
Merged
sfc-gh-nbellante merged 2 commits intodevelopfrom Sep 22, 2025
Merged
[test] Remove problematic 5000ms wait in the e2e's st_audio_input stop_recording#12540sfc-gh-nbellante merged 2 commits intodevelopfrom
sfc-gh-nbellante merged 2 commits intodevelopfrom
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 16, 2025
sfc-gh-nbellante
added
security-assessment-completed
impact:internal
Contributor
📉 Frontend coverage change detectedThe frontend unit test (vitest) coverage has decreased by 0.0000%
✅ Coverage change is within normal range. |
sfc-gh-nbellante
force-pushed
the
remove-problematic-waits
branch
3 times, most recently
from
7ad371f to
31a610e
Compare
sfc-gh-nbellante
force-pushed
the
add-mount-checks
branch
from
862e096 to
8f0bfeb
Compare
sfc-gh-nbellante
force-pushed
the
remove-problematic-waits
branch
from
31a610e to
6b27475
Compare
This was referenced Sep 18, 2025
sfc-gh-nbellante
force-pushed
the
add-mount-checks
branch
from
8f0bfeb to
0d8f61d
Compare
sfc-gh-nbellante
force-pushed
the
remove-problematic-waits
branch
from
6b27475 to
0e0fb7d
Compare
sfc-gh-nbellante
force-pushed
the
add-mount-checks
branch
2 times, most recently
from
06d4203 to
f49c9f8
Compare
sfc-gh-nbellante
force-pushed
the
remove-problematic-waits
branch
from
0e0fb7d to
8f07a70
Compare
sfc-gh-nbellante
force-pushed
the
add-mount-checks
branch
from
f49c9f8 to
91dfac1
Compare
sfc-gh-nbellante
changed the base branch from
add-mount-checks
to
graphite-base/12540
Replace arbitrary 5-second timeout with proper expectations: - Wait for app run to complete - Verify waveform is visible after recording This fixes race condition masking issue where tests could pass even if the recording wasn't properly processed.
sfc-gh-nbellante
force-pushed
the
graphite-base/12540
branch
from
91dfac1 to
b3a1e33
Compare
sfc-gh-nbellante
force-pushed
the
remove-problematic-waits
branch
from
8f07a70 to
71fe8f0
Compare
sfc-gh-nbellante
changed the base branch from
graphite-base/12540
to
develop
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| stop_recording(audio_input, app, wait_for_run=not is_iframe) | ||
| if is_iframe: | ||
| # Give iframe time to process the recording | ||
| app.wait_for_timeout(2000) |
Contributor
There was a problem hiding this comment.
The Streamlit E2E Tests guide explicitly states 'Never use wait_for_timeout' and recommends using the 'wait_until' utility instead. The line 'app.wait_for_timeout(2000)' violates this best practice. Replace this with a proper wait condition using the wait_until utility to wait for a specific state or element rather than an arbitrary timeout.
Suggested change
| app.wait_for_timeout(2000) | |
| app.wait_until(lambda: app.get_by_test_id("stAudioInput").is_visible()) |
Spotted by Diamond (based on custom rule: E2E Playwright Tests)
Is this helpful? React 👍 or 👎 to let us know.
- Replace wait_for_timeout(2000) with expect().to_be_visible() - Only change the line that was already modified in this PR to avoid conflicts - Follow E2E test best practice: avoid wait_for_timeout where possible
sfc-gh-nbellante
changed the title
sfc-gh-bnisco
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This pull request updates the end-to-end Playwright tests for audio input to better handle recording and downloading audio files, especially in iframe contexts. The main improvements include making the recording stop logic more robust and ensuring microphone permissions are granted in iframe tests.
Test robustness and iframe handling:
stop_recordingfunction inst_audio_input_test.pyto accept await_for_runparameter_test_download_audio_fileto detect when running in an iframe and adjust waiting logic accordingly, ensuring reliable test execution in both normal and iframe contexts.Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.