Merged
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
lukasmasuch
added
security-assessment-completed
change:bugfix
Contributor
✅ PR preview is ready!
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a DuckDB integration test by updating the DuckDB relation type detection to support both the new and legacy relation type names. The latest DuckDB release changed the internal type name from duckdb.duckdb.DuckDBPyRelation to _duckdb.DuckDBPyRelation.
- Adds support for the new DuckDB relation type name
_duckdb.DuckDBPyRelation - Maintains backward compatibility with the legacy type name
duckdb.duckdb.DuckDBPyRelation - Improves test error messaging to show the actual type when assertion fails
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/streamlit/dataframe_util.py | Adds new DuckDB relation type constant and updates is_duckdb_relation function to check both new and legacy types |
| lib/tests/streamlit/dataframe_util_test.py | Enhances test assertion with better error message showing actual type when check fails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The duckdb relation name got updated in the latest release. This adds support for the new to get our integration tests running again.
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.