[AdvancedLayouts] Add width to st.vega_lite_chart#12517
Merged
sfc-gh-lwilby merged 8 commits intodevelopfrom Sep 19, 2025
Merged
[AdvancedLayouts] Add width to st.vega_lite_chart#12517sfc-gh-lwilby merged 8 commits intodevelopfrom
st.vega_lite_chart#12517sfc-gh-lwilby merged 8 commits intodevelopfrom
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
st.vega_lite_chartst.vega_lite_chart
sfc-gh-bnisco
approved these changes
Sep 18, 2025
| vega_chart: Locator, | ||
| expected_width: int, | ||
| description: str | None = None, | ||
| tolerance: int = 0, |
Collaborator
There was a problem hiding this comment.
question: Can you leave some comments at the callsites as to why using a tolerance value is necessary for certain cases?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR is part of the [AdvancedLayouts] project and introduces a new width parameter to the st.vega_lite_chart.
This PR also begins the process of deprecating use_container_width. The default is updated to None, and width will be used instead. If the user explicitly passes a value for use_container_width then that will take precedence. use_container_width=True is equivalent to width="stretch" and use_container_width=False is equivalent to width="content". The user will be given a warning and suggestion to use width instead. We will remove use_container_width after 12-31-2025`.
If you use
widthin the spec and also provide the width parameter, the parameter takes precedence. Usewidth="content"if you want to use width in the spec.GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.