[chore] Modify Playwright changed files workflow#12480
Merged
sfc-gh-nbellante merged 3 commits intodevelopfrom Sep 10, 2025
Merged
[chore] Modify Playwright changed files workflow#12480sfc-gh-nbellante merged 3 commits intodevelopfrom
sfc-gh-nbellante merged 3 commits intodevelopfrom
Conversation
…success message icon in st_alert.py to test
Contributor
✅ PR preview is ready!
|
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sfc-gh-nbellante
changed the title
sfc-gh-nbellante
added
impact:internal
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Playwright E2E testing workflow to trigger snapshot tests for both direct test file changes and changes to corresponding source files that have associated test files. Previously, the workflow only monitored *_test.py files directly, missing cases where changes to source files should trigger their corresponding test files to run.
- Expands file monitoring to include both test files and their corresponding source files
- Adds deduplication logic to prevent running the same test multiple times
- Maintains existing filtering for custom components and deleted files
lukasmasuch
approved these changes
Sep 10, 2025
Collaborator
lukasmasuch
left a comment
lukasmasuch
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for updating!
sfc-gh-lmasuch
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR stemmed from #12473 (review)
I noticed that the changed files workflow didn't fail the snapshots as I expected. After talking with @lukasmasuch he said it's because it only looks for changes to the _test.py files. This PR changes it so that it will look at both.
GitHub Issue Link (if applicable)
Testing Plan
I tested it by changing the icon in st_alert.py and ensuring that the workflow failed as expected.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.