[chore] Adding latest material icons#12473
Merged
sfc-gh-nbellante merged 3 commits intodevelopfrom Sep 9, 2025
Merged
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
sfc-gh-nbellante
changed the title
sfc-gh-nbellante
added
security-assessment-completed
change:chore
lukasmasuch
approved these changes
Sep 9, 2025
Collaborator
lukasmasuch
left a comment
lukasmasuch
left a comment
There was a problem hiding this comment.
LGTM 👍 but needs an updated alert snapshot.
sfc-gh-nbellante
added a commit
that referenced
this pull request
Sep 10, 2025
## Describe your changes <!-- If it's a visual change, please include a screenshot or video! --> This PR stemmed from #12473 (review) I noticed that the changed files workflow didn't fail the snapshots as I expected. After talking with @lukasmasuch he said it's because it only looks for changes to the _test.py files. This PR changes it so that it will look at both. ## GitHub Issue Link (if applicable) ## Testing Plan I tested it by changing the icon in st_alert.py and ensuring that the workflow failed as expected. <img width="1101" height="434" alt="image" src="https://github.com/user-attachments/assets/6a0b16e2-9f58-4519-8623-facacac18dc1" /> --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updating the latest material icons
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.