Add default text colors to theme#12407
Merged
mayagbarnes merged 7 commits intodevelopfrom Sep 5, 2025
Merged
Conversation
mayagbarnes
added
security-assessment-completed
change:refactor
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
mayagbarnes
changed the title
lukasmasuch
reviewed
Sep 4, 2025
Collaborator
There was a problem hiding this comment.
The gray background color also changed in this screenshot update. Is that expected?
Collaborator
Author
There was a problem hiding this comment.
This looks like the text color changes pushed these over the threshold - the default background colors PR updated the dark_theme versions of this set of snaps, but not the light_theme ones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add the following main color keys, with defaults for streamlit light/dark themes:
redTextColororangeTextColoryellowTextColorblueTextColorgreenTextColorvioletTextColorgrayTextColorText colors apply to:
st.warning,st.success,st.info,st.error,st.exception) textst.badgetextst.metricdelta text (red/green/gray text colors)st.help(greenTextColor)st.file_uploader,st.chat_input) (redTextColor)theme.linkColor) (blueTextColor)Testing Plan