Merged
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
Contributor
📈 Python coverage change detectedThe Python unit test coverage has increased by 0.3096%
🎉 Great job on improving test coverage! Coverage by files
|
lukasmasuch
changed the title
lukasmasuch
commented
Sep 1, 2025
| cli_util.print_to_cli("") | ||
|
|
||
|
|
||
| def _maybe_print_old_git_warning(main_script_path: str) -> None: |
Collaborator
Author
There was a problem hiding this comment.
This is a very old check. I don't think we need it to support this anymore for an 8-year-old git version.
lukasmasuch
added
change:refactor
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes git utilities by removing outdated version checks and making repository URL parsing more robust. The changes simplify git repository handling, improve debugging capabilities, and add comprehensive test coverage for URL extraction logic.
Key Changes
- Removes check for git versions older than 2.7.0 (which is >8 years old)
- Replaces separate regex patterns with a unified GitHub URL extractor function
- Adds debug logging for error scenarios in git operations
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/streamlit/git_util.py | Replaces regex patterns with unified URL extractor, adds debug logging, removes old git version constant |
| lib/streamlit/web/bootstrap.py | Removes old git version warning function and its usage |
| lib/streamlit/runtime/app_session.py | Adds debug logging for successful git information retrieval |
| lib/tests/streamlit/git_util_test.py | Adds comprehensive parametrized tests for URL extraction and new unit tests for git repo scenarios |
| lib/tests/streamlit/web/bootstrap_test.py | Removes test for old git version warning |
sfc-gh-bnisco
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Applies a couple of improvements to the git module:
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.