Merged
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
sfc-gh-lwilby
added
security-assessment-completed
change:bugfix
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the html element where float values for width and height parameters were being silently ignored and set to defaults instead of being converted to integers. The fix ensures float values are properly handled by converting them to integers.
Key Changes
- Updated width and height validation to accept both int and float types
- Added explicit conversion of float values to integers for pixel dimensions
lukasmasuch
approved these changes
Aug 28, 2025
Collaborator
lukasmasuch
left a comment
lukasmasuch
left a comment
There was a problem hiding this comment.
LGTM 👍 I generate a couple of unit tests for layout_utils to cover this aspect.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
lukasmasuch
added a commit
that referenced
this pull request
Aug 29, 2025
## Describe your changes The `html` element has width and height parameters which accept an integer or None. Previously, we had no validation for the type and it was possible to provide a float value. A recent change converted these elements to the new width/height system and as part of that float values were silently ignored and set to the default (stretch). <!-- If it's a visual change, please include a screenshot or video! --> ## GitHub Issue Link (if applicable) Closes #12340 ## Testing Plan I didn't add new tests for this because it isn't officially supported. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license. --------- Co-authored-by: lukasmasuch <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The
htmlelement has width and height parameters which accept an integer or None. Previously, we had no validation for the type and it was possible to provide a float value. A recent change converted these elements to the new width/height system and as part of that float values were silently ignored and set to the default (stretch).GitHub Issue Link (if applicable)
Closes #12340
Testing Plan
I didn't add new tests for this because it isn't officially supported.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.