Fix issue with typing formatted values into st.number_input#12351
Merged
lukasmasuch merged 3 commits intodevelopfrom Aug 28, 2025
Merged
Fix issue with typing formatted values into st.number_input#12351lukasmasuch merged 3 commits intodevelopfrom
st.number_input#12351lukasmasuch merged 3 commits intodevelopfrom
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
lukasmasuch
added
security-assessment-completed
change:bugfix
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression in the st.number_input component where typing decimal values was problematic due to immediate formatting overriding user input. The fix ensures that while the input field is focused, raw user input is displayed instead of the formatted value, preventing keystrokes from being overridden.
Key changes:
- Modified the display logic to show unformatted values during user input
- Added comprehensive e2e test coverage for decimal input via keyboard
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
frontend/lib/src/components/widgets/NumberInput/NumberInput.tsx |
Introduces displayValue logic to bypass formatting during focus, preventing input interference |
e2e_playwright/st_number_input_test.py |
Adds e2e test to verify decimal input functionality works correctly |
sfc-gh-bnisco
approved these changes
Aug 27, 2025
| ) | ||
|
|
||
|
|
||
| def test_number_input_typing_decimal_via_keyboard(app: Page): |
Collaborator
There was a problem hiding this comment.
question: Just to double-check, this test would have failed before this fix, correct?
Collaborator
Author
There was a problem hiding this comment.
Yep, I tested it manually -> it would have failed in the current state.
lukasmasuch
added a commit
that referenced
this pull request
Aug 29, 2025
## Describe your changes Fix a regression that makes it very hard to type in decimal numbers into `st.number_input`. ## GitHub Issue Link (if applicable) - Closes #12349 ## Testing Plan - Added e2e test that uses type and a decimal number. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
lukasmasuch
added a commit
that referenced
this pull request
Sep 17, 2025
## Describe your changes Manually reverts the logic from these two changes to prevent some unexpected issues with NumberInput usage: - #12351 - #11885 ## GitHub Issue Link (if applicable) - Closes #12526 - Maybe related to #12465 ## Testing Plan - Added e2e test for one of the regression, the rest should be covered well with the existing tests. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license. --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fix a regression that makes it very hard to type in decimal numbers into
st.number_input.GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.