[feat] Hover, active, focus-visible states for CopyButton#12348
Merged
sfc-gh-bnisco merged 2 commits intodevelopfrom Aug 27, 2025
Merged
[feat] Hover, active, focus-visible states for CopyButton#12348sfc-gh-bnisco merged 2 commits intodevelopfrom
sfc-gh-bnisco merged 2 commits intodevelopfrom
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
sfc-gh-bnisco
added
security-assessment-completed
change:feature
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the CopyButton component in CodeBlock with improved interactive states and accessibility features. The changes add proper hover, active, and focus-visible CSS states along with an accessible label that updates based on the copy state.
- Separates hover states for the code block container vs. the button itself
- Adds visual feedback with background colors and focus rings for better user experience
- Improves accessibility with dynamic aria-label and proper button type
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
frontend/lib/src/components/elements/CodeBlock/styled-components.ts |
Refactors CSS selectors to separate container hover from button states, adds hover/active background colors and focus-visible ring |
frontend/lib/src/components/elements/CodeBlock/CopyButton.tsx |
Adds dynamic aria-label and title that updates based on copy state, sets explicit button type |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Dark mode:
Kapture.2025-08-27.at.08.50.40.mp4
Light mode:
Kapture.2025-08-27.at.08.51.22.mp4
Focus ring when keyboard focus:
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.