-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add default background colors to theme #12341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c97f96c
First pass
mayagbarnes 2941d40
Update snaps - chat/divider
mayagbarnes 559b1ab
Remove yellow, add FE tests
mayagbarnes a475968
Update mockTheme
mayagbarnes 09f0e12
Update metric sparkline green/red
mayagbarnes cbe8f77
Update metric snaps
mayagbarnes 0feec48
Add todo
mayagbarnes 053183a
First pass
mayagbarnes f4376e7
Merge branch 'develop' into default-background-colors
mayagbarnes 32bce04
Add note
mayagbarnes a14f6c5
Merge branch 'develop' into default-background-colors
mayagbarnes fc2246e
Update snaps
mayagbarnes b48db2b
Update e2e part 2
mayagbarnes c0bd2b7
Move hardcoded values to primitives
mayagbarnes 21aa664
Merge branch 'develop' into default-background-colors
mayagbarnes 2ef6e92
Fix nits
mayagbarnes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
-158 Bytes
(100%)
...laywright/__snapshots__/linux/custom_theme_test/custom_themed_app[chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-50 Bytes
(100%)
...playwright/__snapshots__/linux/custom_theme_test/custom_themed_app[firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-60 Bytes
(100%)
e2e_playwright/__snapshots__/linux/custom_theme_test/custom_themed_app[webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-77 Bytes
(100%)
..._snapshots__/linux/sidebar_custom_theme_test/sidebar_custom_theme[chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-34 Bytes
(100%)
...__snapshots__/linux/sidebar_custom_theme_test/sidebar_custom_theme[firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-26 Bytes
(100%)
.../__snapshots__/linux/sidebar_custom_theme_test/sidebar_custom_theme[webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-35 Bytes
(99%)
...itor_config_test/st_data_editor-multiselect_col_editor[dark_theme-chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-60 Bytes
(99%)
...ditor_config_test/st_data_editor-multiselect_col_editor[dark_theme-firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-95 Bytes
(98%)
...editor_config_test/st_data_editor-multiselect_col_editor[dark_theme-webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-20 Bytes
(100%)
..._dataframe_config_test/st_dataframe-multiselect_column[dark_theme-chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-101 Bytes
(99%)
...t_dataframe_config_test/st_dataframe-multiselect_column[dark_theme-firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-147 Bytes
(99%)
...st_dataframe_config_test/st_dataframe-multiselect_column[dark_theme-webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+476 Bytes
(100%)
...snapshots__/linux/st_exception_test/st_exception-basic[light_theme-firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+37 Bytes
(100%)
...__snapshots__/linux/st_markdown_test/st_badge-examples[dark_theme-chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+267 Bytes
(100%)
.../__snapshots__/linux/st_markdown_test/st_badge-examples[dark_theme-firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+201 Bytes
(100%)
...t/__snapshots__/linux/st_markdown_test/st_badge-examples[dark_theme-webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+13 Bytes
(100%)
...napshots__/linux/st_markdown_test/st_badge-width_100px[dark_theme-chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-11 Bytes
(99%)
...snapshots__/linux/st_markdown_test/st_badge-width_100px[dark_theme-firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4 Bytes
(100%)
..._snapshots__/linux/st_markdown_test/st_badge-width_100px[dark_theme-webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1 Byte
(100%)
...pshots__/linux/st_markdown_test/st_badge-width_content[dark_theme-chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1 Byte
(100%)
...apshots__/linux/st_markdown_test/st_badge-width_content[dark_theme-firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-25 Bytes
(99%)
...napshots__/linux/st_markdown_test/st_badge-width_content[dark_theme-webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+16 Bytes
(100%)
...pshots__/linux/st_markdown_test/st_badge-width_stretch[dark_theme-chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+9 Bytes
(100%)
...apshots__/linux/st_markdown_test/st_badge-width_stretch[dark_theme-firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-54 Bytes
(98%)
...napshots__/linux/st_markdown_test/st_badge-width_stretch[dark_theme-webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.05 KB
(99%)
...t_markdown_test/st_markdown-many_elements_in_one_block[dark_theme-chromium].png
Oops, something went wrong.
Binary file modified
BIN
-55 Bytes
(100%)
...st_markdown_test/st_markdown-many_elements_in_one_block[dark_theme-firefox].png
Oops, something went wrong.
Binary file modified
BIN
-486 Bytes
(99%)
.../st_markdown_test/st_markdown-many_elements_in_one_block[dark_theme-webkit].png
Oops, something went wrong.
Binary file modified
BIN
-247 Bytes
(95%)
...ht/__snapshots__/linux/st_metric_test/st_metric-border[dark_theme-chromium].png
Oops, something went wrong.
Binary file modified
BIN
+31 Bytes
(100%)
...ght/__snapshots__/linux/st_metric_test/st_metric-border[dark_theme-firefox].png
Oops, something went wrong.
Binary file modified
BIN
-98 Bytes
(98%)
...ight/__snapshots__/linux/st_metric_test/st_metric-border[dark_theme-webkit].png
Oops, something went wrong.
Binary file modified
BIN
-12 Bytes
(100%)
...snapshots__/linux/st_metric_test/st_metric-chart_hover[dark_theme-chromium].png
Oops, something went wrong.
Binary file modified
BIN
+51 Bytes
(100%)
..._snapshots__/linux/st_metric_test/st_metric-chart_hover[dark_theme-firefox].png
Oops, something went wrong.
Binary file modified
BIN
-36 Bytes
(100%)
...__snapshots__/linux/st_metric_test/st_metric-chart_hover[dark_theme-webkit].png
Oops, something went wrong.
Binary file modified
BIN
-103 Bytes
(97%)
...napshots__/linux/st_metric_test/st_metric-code_in_help[dark_theme-chromium].png
Oops, something went wrong.
Binary file modified
BIN
+4 Bytes
(100%)
...ight/__snapshots__/linux/st_metric_test/st_metric-gray[dark_theme-chromium].png
Oops, something went wrong.
Binary file modified
BIN
+23 Bytes
(100%)
...right/__snapshots__/linux/st_metric_test/st_metric-gray[dark_theme-firefox].png
Oops, something went wrong.
Binary file modified
BIN
+3 Bytes
(100%)
...wright/__snapshots__/linux/st_metric_test/st_metric-gray[dark_theme-webkit].png
Oops, something went wrong.
Binary file modified
BIN
-18 Bytes
(100%)
...ght/__snapshots__/linux/st_metric_test/st_metric-green[dark_theme-chromium].png
Oops, something went wrong.
Binary file modified
BIN
+56 Bytes
(100%)
...ight/__snapshots__/linux/st_metric_test/st_metric-green[dark_theme-firefox].png
Oops, something went wrong.
Binary file modified
BIN
-41 Bytes
(99%)
...right/__snapshots__/linux/st_metric_test/st_metric-green[dark_theme-webkit].png
Oops, something went wrong.
Binary file modified
BIN
+26 Bytes
(100%)
...ots__/linux/st_metric_test/st_metric-help_and_ellipses[dark_theme-chromium].png
Oops, something went wrong.
Binary file modified
BIN
-18 Bytes
(100%)
...hots__/linux/st_metric_test/st_metric-help_and_ellipses[dark_theme-firefox].png
Oops, something went wrong.
Binary file modified
BIN
+46 Bytes
(100%)
...shots__/linux/st_metric_test/st_metric-help_and_ellipses[dark_theme-webkit].png
Oops, something went wrong.
Binary file modified
BIN
+23 Bytes
(100%)
...pshots__/linux/st_metric_test/st_metric-label_collapse[dark_theme-chromium].png
Oops, something went wrong.
Binary file modified
BIN
+8 Bytes
(100%)
...apshots__/linux/st_metric_test/st_metric-label_collapse[dark_theme-firefox].png
Oops, something went wrong.
Binary file modified
BIN
+34 Bytes
(100%)
...napshots__/linux/st_metric_test/st_metric-label_collapse[dark_theme-webkit].png
Oops, something went wrong.
Binary file modified
BIN
+23 Bytes
(100%)
...napshots__/linux/st_metric_test/st_metric-label_hidden[dark_theme-chromium].png
Oops, something went wrong.
Binary file modified
BIN
-19 Bytes
(100%)
...snapshots__/linux/st_metric_test/st_metric-label_hidden[dark_theme-firefox].png
Oops, something went wrong.
Binary file modified
BIN
+34 Bytes
(100%)
..._snapshots__/linux/st_metric_test/st_metric-label_hidden[dark_theme-webkit].png
Oops, something went wrong.
Binary file modified
BIN
-157 Bytes
(98%)
...pshots__/linux/st_metric_test/st_metric-markdown_label[dark_theme-chromium].png
Oops, something went wrong.
Binary file modified
BIN
+11 Bytes
(100%)
...apshots__/linux/st_metric_test/st_metric-markdown_label[dark_theme-firefox].png
Oops, something went wrong.
Binary file modified
BIN
-7 Bytes
(100%)
...napshots__/linux/st_metric_test/st_metric-markdown_label[dark_theme-webkit].png
Oops, something went wrong.
Binary file modified
BIN
-147 Bytes
(98%)
...right/__snapshots__/linux/st_metric_test/st_metric-red[dark_theme-chromium].png
Oops, something went wrong.
Binary file modified
BIN
-27 Bytes
(100%)
...wright/__snapshots__/linux/st_metric_test/st_metric-red[dark_theme-firefox].png
Oops, something went wrong.
Binary file modified
BIN
-127 Bytes
(98%)
...ywright/__snapshots__/linux/st_metric_test/st_metric-red[dark_theme-webkit].png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
personal taste: as a side-by-side comparison, the background colors in dark mode seems to be a bit less "colorful" / dull / less distinguishable (also see the MultiselectColumn tags above). 20% transparency might be a bit too much, and something between 10-20% would be a bit better. cc @jrieke
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats fair, will make a note to revisit (in any way, yellow bg was noted above as a concern)